Add to_proto to descriptor classes
#19971
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is the same name function in `upb/util/def_to_proto.c`. https://github.com/protocolbuffers/protobuf/blob/c8ad77475634f77468cd237dd10bcff978a2372a/upb/util/def_to_proto.c#L57 The amalgamation merges `upb` files into one file. So, it causes a compile error when the functions have the same name.
y-yagi
requested review from
JasonLunn and
bshaffer
and removed request for
a team
y-yagi
commented
Jan 12, 2025
| @@ -181,7 +181,7 @@ bool upb_FileDef_Resolves(const upb_FileDef* f, const char* path) { | |||
| return false; | |||
| } | |||
|
|
|||
| static char* strviewdup(upb_DefBuilder* ctx, upb_StringView view) { | |||
| static char* _strviewdup(upb_DefBuilder* ctx, upb_StringView view) { | |||
There was a problem hiding this comment.
I renamed this because there is the same name function in upb/util/def_to_proto.c.
protobuf/upb/util/def_to_proto.c
Line 57 in c8ad774
The amalgamation merges upb files into one file. So, it causes a compile error when the functions have the same name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some APIs (e.g. BigQuery Storage) use DescriptorProto for schema descriptions. But, in Ruby, there are no methods for that so far.
This PR implements the method for that(`to_proto) to descriptor classes.
Fixes #12044.