Use bit-field int values in buildPartial to skip work on unset groups of fields. #10960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of fields. Changes to make this improvement: 1) All non-repeated builder fields (including maps) now have a presence bit regardless of syntax. 2) The buildPartial method is split into one method per 32-field block (aligned with bit-mask ints) 3) If a presence bit-mask int is set to 0, no fields are present, so we can skip the logic for all of those fields in the buildPartial step. For messages with a lot of fields (> 100) that are sparsely populated this can result in a significant improvement. Not only does it potentially skip a lot of field copying logic, but also breaks the buildPartial method into chunks that should be more easily digested by the JIT compiler as discussed in this issue: #10247. PiperOrigin-RevId: 485952448
shaod2
approved these changes
Nov 14, 2022
Merged
gengliangwang
added a commit
to apache/spark
that referenced
this pull request
Dec 13, 2022
### What changes were proposed in this pull request? Upgrade Protobuf version to 3.21.11 ### Why are the changes needed? There are some bug fixes in the latest release https://github.com/protocolbuffers/protobuf/releases: * Use bit-field int values in buildPartial to skip work on unset groups of fields. (protocolbuffers/protobuf#10960) * Mark nested builder as clean after clear is called (protocolbuffers/protobuf#10984) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? GA tests Closes #39042 from gengliangwang/upgradeProtobuf. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? Upgrade Protobuf version to 3.21.11 ### Why are the changes needed? There are some bug fixes in the latest release https://github.com/protocolbuffers/protobuf/releases: * Use bit-field int values in buildPartial to skip work on unset groups of fields. (protocolbuffers/protobuf#10960) * Mark nested builder as clean after clear is called (protocolbuffers/protobuf#10984) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? GA tests Closes apache#39042 from gengliangwang/upgradeProtobuf. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to make this improvement:
All non-repeated builder fields (including maps) now have a presence bit regardless of syntax.
The buildPartial method is split into one method per 32-field block (aligned with bit-mask ints)
If a presence bit-mask int is set to 0, no fields are present, so we can skip the logic for all of those fields in the buildPartial step.
For messages with a lot of fields (> 100) that are sparsely populated this can result in a significant improvement. Not only does it potentially skip a lot of field copying logic, but also breaks the buildPartial method into chunks that should be more easily digested by the JIT compiler as discussed in this issue: #10247.
PiperOrigin-RevId: 485952448