Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please yank 4.21.0 which pip installs for Python versions < 3.7 #10076

Closed
jtfung opened this issue May 29, 2022 · 2 comments
Closed

Please yank 4.21.0 which pip installs for Python versions < 3.7 #10076

jtfung opened this issue May 29, 2022 · 2 comments
Assignees
Labels

Comments

@jtfung
Copy link

jtfung commented May 29, 2022

Apologies if this is the wrong place for this issue ...

I tried installing the latest version of protobuf after it was released yesterday, hoping that the latest version fixes a problem where an incompatible 4.21.0 (which is missing metadata and/or attributes, I don't know which) gets installed on Python versions < 3.7. No luck.

Here is a failed attempt to install a "compatible" version with Python 3.6.x:

$ date
Sat May 28 22:11:23 MDT 2022

$ python --version
Python 3.6.9

$ pip --version
pip 21.3.1 from ...

$ pip install --no-cache-dir protobuf
Collecting protobuf
...
Successfully installed protobuf-4.21.0

Here's a successful attempt to install a compatible versions with Python 3.8.x (I would expect the same result with Python >= 3.7x):

$ date
Sat May 28 21:15:21 PDT 2022

$ python --version
Python 3.8.12

$ pip --version
pip 21.1.1 from ...

$ pip install --no-cache-dir protobuf
Collecting protobuf
...
Successfully installed protobuf-4.21.1

Please yank 4.21.0! Thank you.

@zifban
Copy link

zifban commented May 30, 2022

I second this. Please (re-)yank 4.21.0. The code there uses f-strings that are not supported by Python 3.5.

How to replicate:

$ docker run --rm -it python:3.5 /bin/bash
# pip install -q -U pip
# pip install -q protobuf
# pip list
Package    Version
---------- -------
pip        20.3.4
protobuf   4.21.0
setuptools 50.3.0
wheel      0.35.1
# python -c 'import google.protobuf.reflection'
...
    from google.protobuf.internal import containers
  File "/usr/local/lib/python3.5/site-packages/google/protobuf/internal/containers.py", line 349
    f'{self.__class__.__name__} object does not support item assignment')
                                                                       ^
SyntaxError: invalid syntax

@zhangskz zhangskz self-assigned this May 31, 2022
@zhangskz
Copy link
Member

Thanks for bringing this up -- we've yanked 4.21.0.

We believe this should no longer be an issue in 4.21.1 per #10053

freyes added a commit to freyes/zaza that referenced this issue Dec 14, 2023
macaroonbakery in version 1.3.4 started depending on protobuf>3.20 which
it's not compatible with python 3.6, so this change pins macaroonbakery
to 1.3.2 which was the last release compatible with older versions of
protobuf.

For more details see:

- go-macaroon-bakery/py-macaroon-bakery#92
- protocolbuffers/protobuf#10076

It's worth to mention that there is no protobuf-4.0, it goes from 3.20
to 4.21 - https://pypi.org/project/protobuf/#history
freyes added a commit to freyes/zaza that referenced this issue Dec 14, 2023
macaroonbakery in version 1.3.4 started depending on protobuf>3.20 which
it's not compatible with python 3.6, so this change pins macaroonbakery
to 1.3.2 which was the last release compatible with older versions of
protobuf.

For more details see:

- go-macaroon-bakery/py-macaroon-bakery#92
- protocolbuffers/protobuf#10076

It's worth to mention that there is no protobuf-4.0, it goes from 3.20
to 4.21 - https://pypi.org/project/protobuf/#history

(cherry picked from commit a8e4de5)
freyes added a commit to freyes/zaza that referenced this issue Dec 14, 2023
macaroonbakery in version 1.3.4 started depending on protobuf>3.20 which
it's not compatible with python 3.6, so this change pins macaroonbakery
to 1.3.2 which was the last release compatible with older versions of
protobuf.

For more details see:

- go-macaroon-bakery/py-macaroon-bakery#92
- protocolbuffers/protobuf#10076

It's worth to mention that there is no protobuf-4.0, it goes from 3.20
to 4.21 - https://pypi.org/project/protobuf/#history

(cherry picked from commit a8e4de5)
(cherry picked from commit 300c5bb)
freyes added a commit to freyes/zaza that referenced this issue Dec 14, 2023
macaroonbakery in version 1.3.4 started depending on protobuf>3.20 which
it's not compatible with python 3.6, so this change pins macaroonbakery
to 1.3.2 which was the last release compatible with older versions of
protobuf.

For more details see:

- go-macaroon-bakery/py-macaroon-bakery#92
- protocolbuffers/protobuf#10076

It's worth to mention that there is no protobuf-4.0, it goes from 3.20
to 4.21 - https://pypi.org/project/protobuf/#history

(cherry picked from commit a8e4de5)
(cherry picked from commit 300c5bb)
freyes added a commit to freyes/zaza that referenced this issue Dec 14, 2023
macaroonbakery in version 1.3.4 started depending on protobuf>3.20 which
it's not compatible with python 3.6, so this change pins macaroonbakery
to 1.3.2 which was the last release compatible with older versions of
protobuf.

For more details see:

- go-macaroon-bakery/py-macaroon-bakery#92
- protocolbuffers/protobuf#10076

It's worth to mention that there is no protobuf-4.0, it goes from 3.20
to 4.21 - https://pypi.org/project/protobuf/#history

(cherry picked from commit a8e4de5)
(cherry picked from commit 300c5bb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants