Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

fix: semver comparison for prereleases in release-check #509

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Mar 31, 2023

Closes #508

With this change, the release-check will take into account prerelease versions when looking for a version to compare to when releasing a prerelease version.

The behaviour for releasing non-prerelease versions does not change.

@marten-seemann
Copy link
Contributor

Comparing to the last actual release (i.e. the current behavior) is the correct thing to do.
There's no API guarantees for pre-release versions. Comparing to pre-releases will make us miss breaking changes.

@galargh
Copy link
Contributor Author

galargh commented Mar 31, 2023

I'm only proposing to compare pre-releases to pre-releases where I think it could make sense. I'll let @aschmahmann to advocate for it, given #508.

@aschmahmann
Copy link
Contributor

There's no API guarantees for pre-release versions. Comparing to pre-releases will make us miss breaking changes.

How? When you go from v0.X.0 to v0.X+1.0-rc1 you'll have a bunch of breaking changes. Then at some point you make an v0.X.+1.0-rc2, don't you want to know the delta vs rc1? If rc1 had a lot of breaking changes then rc2,3,... all have a ton of noise in the checks.

v0.X.0-rc1 would still show changes from x0.X.0 and v0.X.1 (or v0.X+1.0) would also show the changes from v0.X.0.

@marten-seemann
Copy link
Contributor

I'm only proposing to compare pre-releases to pre-releases where I think it could make sense. I'll let @aschmahmann to advocate for it, given #508.

As long as we're still showing the full list of changes since v0.X-1 when cutting v0.X that makes sense to me.

@galargh galargh merged commit 662e8df into master Jul 20, 2023
28 checks passed
@galargh galargh deleted the fix/prerelease-check branch July 20, 2023 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Check workflow not comparing the correct versions for Golang RCs
3 participants