Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

feat: do not hardcode Go version in workflows #491

Merged
merged 8 commits into from
Jul 20, 2023
Merged

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Mar 9, 2023

This attempts to read required Go version from go.mod (using go mod edit -json) rather than hardcoding it in the workflow.

Testing

@galargh galargh changed the title wip: do not hardcode Go version in workflows feat: do not hardcode Go version in workflows Apr 3, 2023
@galargh galargh marked this pull request as ready for review April 3, 2023 10:34
@galargh galargh requested a review from a team as a code owner April 3, 2023 10:34
Copy link
Contributor

@laurentsenta laurentsenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question on version constraints that you probably already thought about, rest looks great 👍

@galargh galargh changed the base branch from next to unified-ci-2.0 July 20, 2023 12:08
@galargh galargh merged commit b8f484d into unified-ci-2.0 Jul 20, 2023
33 checks passed
@galargh galargh deleted the no-go branch July 20, 2023 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants