This repository was archived by the owner on Aug 29, 2023. It is now read-only.
Create GitHub releases in releaser/tag-pusher workflows #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "include cross-package coverage in codecov"
…ross-package Revert "Revert "include cross-package coverage in codecov""
* move automerge from template to workflows * make automerge reusable and use it from new automerge template * pass parent job name to reusable automerge
* check github actions yamls * make yaml linter happy about go-test * mention VS Code YAML extension in the readme * add info about other YAML checking extensions * make yaml checker more generic
galargh
added a commit
to galorgh/go-ipfs-cmds
that referenced
this pull request
Feb 24, 2022
galargh
force-pushed
the
github-release
branch
11 times, most recently
from
4242e0a to
a230d86
Compare
galargh
added a commit
to galorgh/go-ipfs-cmds
that referenced
this pull request
Feb 24, 2022
galargh
force-pushed
the
github-release
branch
2 times, most recently
from
1186400 to
96c2ec8
Compare
galargh
force-pushed
the
github-release
branch
3 times, most recently
from
703a7d3 to
4c73325
Compare
galargh
force-pushed
the
github-release
branch
from
4c73325 to
3dfc692
Compare
galargh
changed the title
laurentsenta
reviewed
Jan 5, 2023
| # Check if a git tag for the version (as read from version.json) exists | ||
| # If that is the case, we don't need to run the rest of the workflow. | ||
| if: env.VERSION != '' | ||
| echo "::set-output name=this::$version" |
Contributor
There was a problem hiding this comment.
Should we use echo "{name}={value}" >> $GITHUB_OUTPUT ?
laurentsenta
reviewed
Jan 5, 2023
| if: env.TAG_EXISTS == 'false' | ||
| run: npm install -g "https://github.com/npm/node-semver#e79ac3a450e8bb504e78b8159e3efc7089569" # v7.3.5 | ||
| # https://docs.github.com/en/rest/reference/git#get-a-reference | ||
| gh api '/repos/${{ github.repository }}/git/ref/tags/${{ steps.version.outputs.this }}' && tag_exists='true' || tag_exists='false' |
Contributor
There was a problem hiding this comment.
We're using string interpolation at the yml level here, is it possible a malformed value in steps.version.outputs.this turns into a string injection?
Should we use something like:
env:
TAG_URL: /repos/${{ github.repository }}/git/ref/tags/${{ steps.version.outputs.this }}
run:
gh api "${TAG_URL}" # using shell's expansion here?
laurentsenta
reviewed
Jan 5, 2023
| status=$? && ([[ $status == 0 ]] || exit $status) | ||
| fi | ||
| echo "COMMENT<<EOF |
Contributor
There was a problem hiding this comment.
TIL... cool pattern :)
Do we need to worry about script injection here?
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings
Contributor
Author
|
Moved back to draft for now. I'm going to asses the comments from @laurentsenta and mark it as ready for review afterwards. Thanks 🙇 |
Contributor
Author
|
Replaced this one with #456 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #228
Description
This PR builds up on #295. It is currently targeted at that PR. It can be retargeted to
nextonce that PR is merged.In this PR I refactor
release-checkandreleaserworkflows in such a way that enables adding GitHub Release creation to the process. I propose for a draft GitHub Release to be created duringrelease-checkand for that draft to be published duringrelease.release-checkwill post a link to the draft as a comment. The draft can be modified or deleted manually - those actions will be respected by therelease.I describe what the refactored workflows are doing below.
release-checkversion.jsonthrough GitHub APIgoreleaseandgocompatif a previous version existsreleaseversion.jsonthrough GitHub APIreleaselabel on it - exit if not on a default branch and such a PR does not existTesting
Default branch
Release branch