Skip to content
This repository was archived by the owner on Aug 29, 2023. It is now read-only.

Conversation

@marten-seemann
Copy link
Contributor

The versioning workflows will be presented at tonight's Demo Day. After that, we can use them everywhere.

Copy link
Contributor

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How confident are you that this won't be a surprise to the majority of maintainers?

I'm thinking back to how it came as a surprise to Hannah for Graphsync, and I'm wondering what we're doing to make sure all maintainers are up to speed.

# We could use a higher number here. We use a small number just to make sure to create multiple batches.
MAX_REPOS_PER_WORKFLOW: 16
FILES: '[ ".github/workflows/automerge.yml", ".github/workflows/go-test.yml", ".github/workflows/go-check.yml" ]' # a JSON array of the files to distribute
FILES: '[ ".github/workflows/automerge.yml", ".github/workflows/go-test.yml", ".github/workflows/go-check.yml", ".github/workflows/releaser.yml", ".github/workflows/release-check.yml", ".github/workflows/tagpush.yml" ]' # a JSON array of the files to distribute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this multi-line?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have to refactor it soon to support JS anyway (here's my proposal - #239) so I think we can leave it as is in this PR.

As for spreading the news about upcoming changes, I think Demo Day announcement is a great idea. Other thing I've seen working fairly well at other places was a dedicated announcement Slack channel, something like #w3dt-unified-ci-releases for example. We'd only ever post info about upcoming releases there and refrain from having other discussions (unless it's in a thread under post about the upcoming release). Do you think something like that could be a good fit at PL?

@marten-seemann
Copy link
Contributor Author

How confident are you that this won't be a surprise to the majority of maintainers?

We can do another announcement in Slack before we hit the merge button.

@galargh galargh merged commit 1307a36 into next Dec 10, 2021
@galargh galargh deleted the make-versioning-default branch December 10, 2021 07:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants