This repository was archived by the owner on Aug 29, 2023. It is now read-only.
use msys2 on Windows #221
Closed
use msys2 on Windows #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
configure-shell
branch
from
da60570 to
60160a3
Compare
Contributor
Author
|
I updated the PR to use v1.3 of multiple-go-modules. |
marten-seemann
force-pushed
the
configure-shell
branch
from
60160a3 to
02fc1fd
Compare
mvdan
approved these changes
Nov 16, 2021
| os: | ||
| - { name: "ubuntu", shell: "bash" } | ||
| - { name: "macos", shell: "bash" } | ||
| - { name: "windows", shell: "msys2 {0}" } |
Contributor
There was a problem hiding this comment.
I wonder if we could derive the shell by default from the OS name, to reduce verbosity.
Contributor
Author
There was a problem hiding this comment.
Not without a separate step I think.
Contributor
There was a problem hiding this comment.
NOTE: this is a breaking change if someone started using os.name in their custom go-test-setup/action.yml. I don't expect there are many (if any) places like this so I can just keep an eye out for failing sync PRs once we propagate this change throughout the repos and fix where needed.
This was referenced Nov 22, 2021
Contributor
|
Closing this since the alternative #232 was merged into |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how our workflows would look like once we merge protocol/multiple-go-modules#8.