Fixed problem with IncludeInOutput not being specified (#1045)

[dxdjgl]

No description provided.

[dxdjgl]

@mgravell This is actually a quite important fix, otherwise all existing usages will have to adapt their project files to include this new option.

[kmosegaard]

Oh, jeez.

I guess, IncludeInOutput is actually by default an empty string (or "") when not specified which bool.TryParse will say is false, causing files not to be generated.

Nice catch and sorry for the blunder.

[kmosegaard]

I tried the following code (using csharp.godbolt.org):

using System;

class Program
{
    static void Main()
    {
        bool result = true;
        var res = bool.TryParse("", out result);
        Console.WriteLine(res);
        Console.WriteLine(result);
    }
}

It seems that both res is false and result is false. So, bool.TryParse must also have overwritten result even though it couldn't be parsed. So, we might have to refine the logic even more.

This is actually documented behavior: https://learn.microsoft.com/en-us/dotnet/api/system.boolean.tryparse?view=net-7.0.

We might have to refine the whole thing to be something like:

var includeInOutput = true;
if (userOptions is not null && userOptions.TryGetValue(Literals.AdditionalFileMetadataPrefix + "IncludeInOutput", out var optionValue) && !bool.TryParse(optionValue, out var includeInOutput))
{
    includeInOutput = true;
}

Other suggestions?

[kmosegaard]

Would be nice if we also extend ProtoGeneratorTests.cs specifically L88 as such:

}", new[] { ("ImportPaths", "../../"), ("IncludeInOutput", "") } ),

With an empty IncludeInOutput to see that the change works.

[mgravell]

Merged to avoid problems, but I might tweak it again shortly - a useful trick is to use a temp for the TryBlah out variable