chore(beads): adopt allowlist .gitignore, untrack history snapshots - #367
Merged
Conversation
Replace .beads/.gitignore with the allowlist form and stop tracking the 92 committed .br_history/ snapshots plus metadata.json. Committed files are now the shared source of truth (issues.jsonl, config.yaml, routes.jsonl, .gitignore); everything else under .beads/ is runtime-local and ignored automatically — no future .gitignore churn as br adds files. Closes bd-32i. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
|
Warning Review limit reached
More reviews will be available in 4 minutes and 37 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (95)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #367 | chore(beads): adopt allowlist .gitignore, untrack history snapshots
VERDICT: WARN (CI non-terminal — formal PASS/FAIL on hold)
CI Status
- Lint: in_progress
- CodeQL: in_progress
Diff Review
The PR does two things: (1) deletes 92+ committed .br_history/ snapshot files (.jsonl + .meta.json pairs) that were bloating the repo, and (2) replaces .beads/.gitignore with the allowlist form. No code logic is changed.
Observations
- LOW: The diff is large (200 lines shown, ~184 files deleted), but the content is exclusively file deletions + a gitignore rewrite — no risk of logic regression. Structural review waived for a pure cleanup chore.
- LOW: The new allowlist
.gitignorefollows the pattern*(deny all) then!.gitignore/!config.yamletc. to explicitly un-ignore the four committed files. This is the correct inverse of the old deny-list and eliminates the need to update.gitignoreevery timebrintroduces a new volatile file type. - INFO: The PR body claims
git check-ignoreverification was run. That step is not visible in the diff, but the gitignore pattern is straightforward and correct. - INFO: Matches protoPen PR #73 and upstream gastownhall/beads#919 per the PR description.
No blocking issues. Will re-review for PASS once CI completes terminal-green.
— Quinn, QA Engineer
|
Submitted COMMENT review on #367. Formal verdict held until CI (Lint, CodeQL) reaches terminal state — this is a clean cleanup PR with no blocking findings. |
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
.beads/.gitignorewith the allowlist form and stops tracking the 92 committed.br_history/snapshots plusmetadata.jsonthat were bloating the repo.issues.jsonl,config.yaml,routes.jsonl,.gitignorebeads.db*,*.lock,.br_history/,daemon.*,metadata.json,.local_version, etc.Robust: any new volatile file
bradds is ignored automatically — no future.gitignorechurn. Matches protoPen PR #73 and upstream gastownhall/beads#919.Verification
git check-ignoreconfirms volatile files are ignored and the four allowlisted files remain tracked.Closes bd-32i.
🤖 Generated with Claude Code