chore(sdk): release v0.3.2 + align CI to NPM_TOKEN - #293
Merged
Conversation
Point sdk-release.yml at the same NPM_TOKEN secret that release.yml uses (was NPM_PUBLISH_TOKEN — a separate, never-CI-proven secret). The CLI's publish was fixed by deleting a stale repo-level NPM_TOKEN that shadowed the valid org-level one (#255); using the same org token here keeps both packages on one confirmed-working credential. Bumps @protolabsai/sdk 0.3.1 → 0.3.2 to give the release workflow a fresh version to publish (verifies the SDK CI publish path end-to-end). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
WalkthroughThe SDK release workflow switches the npm publish authentication from ChangesRelease Preparation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #293 | chore(sdk): release v0.3.2 + align CI to NPM_TOKEN
VERDICT: FAIL
CI Status
- Lint: queued
- CodeQL: in_progress
Diff Review
.github/workflows/sdk-release.yml:76: switchessecrets.NPM_PUBLISH_TOKEN→secrets.NPM_TOKEN, aligning SDK publish to the org token confirmed working after the CLI shadow fix (#255)packages/sdk-typescript/package.json+package-lock.json: version bump 0.3.1 → 0.3.2
Observations
- LOW: Diff is minimal and exactly matches the stated intent — no test surface touched, no new code paths introduced.
- BLOCKER: CI checks have not completed. Cannot approve with pending Lint + CodeQL.
The diff itself is clean. Once CI goes green, re-request review and this will pass.
— Quinn, QA Engineer
|
Submitted REQUEST_CHANGES review on #293. The diff is targeted and correct (token alignment + version bump), but CI has not completed (Lint queued, CodeQL in progress). The review is live on GitHub — once both checks go green, a re-request will land and approval will follow. |
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifies the SDK CI publish path now that the CLI publish is fixed (#255: root cause was a stale repo-level
NPM_TOKENshadowing the org one).sdk-release.ymltoNPM_TOKEN(wasNPM_PUBLISH_TOKEN, a separate secret never proven via CI). Both packages now publish with the same confirmed-working org token.@protolabsai/sdk0.3.1 → 0.3.2 so the release workflow has a fresh version to publish.After merge, I'll tag
sdk-v0.3.2to trigger the release and confirm a clean CI publish (npm currently at 0.3.1). If it 404s, the SDK package likely needs the same publishing-access check the CLI did — but with the shadow gone and the org token confirmed, it should go green.🤖 Generated with Claude Code
Summary by CodeRabbit