fix(ci): sdk-release publishes via OIDC trusted publisher - #245
Merged
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The previous SDK release attempts kept hitting npm's 2FA requirement:
The token was correct — npm's package-level publish protection requires 2FA at publish time regardless of token type. The cleanest fix is OIDC trusted publishing: GitHub Actions mints a short-lived registry token via its OIDC identity, bypassing 2FA enforcement legitimately and eliminating the need for any npm token in CI.
Trusted Publisher for
@protolabsai/sdkis now configured on npm pointing at:protoLabsAI/protoCLIsdk-release.ymlChanges
.github/workflows/sdk-release.ymlid-token: writeto the job'spermissionsblock — required for npm to read the GitHub OIDC token from the workflow context.NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}from the publish step — OIDC supersedes the static token. The secret can stay around in case we need to fall back, or get cleaned up in a follow-up.Side benefits
Validation
actionlintwould catch issues; verified locally by inspection)gh workflow run "SDK Release" --repo protoLabsAI/protoCLI --ref devto attempt publish of@protolabsai/sdk@0.3.0Out of scope
The
NPM_PUBLISH_TOKENorg secret + the stale repo-levelNPM_TOKENare now unused. Leaving them in place for one cycle so the rollback path is trivial if OIDC has unforeseen issues.