Conversation
- README "What's Different" expanded from 6 rows to 17 — covers agent harness, streaming resilience, reasoning models, ACP parity, tools, observability, release pipeline. Glanceable at the top of the README. - New docs/architecture/divergence-from-upstream.md (601 lines): maintainer-oriented breakdown by category — Identity, Inference, ACP/Session, Tooling, Configuration, Agent Harness, UI, Build/Release, Telemetry, Removed Surfaces, Intentionally Not Ported, Areas Behind. Co-authored-by: Automaker <automaker@localhost> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
De-dupes the heavy "The X is …" pattern and adds six new themed sections: - **Dry / office passive-aggressive** — varied openings, fragments, gerunds - **Retro 90s/2000s tech** — VHS, dial-up, AIM, ICQ, MapQuest, the Zune - **Movies / TV** — recognizable lines, recompiled - **Songs** — earworms re-purposed - **Sedaris-y observational** — "An ex tagged me in a photo from 2007" - **Surreal / nonsensical** — "Sorting the bees by mood" - **Begrudgingly helpful coding assistant** — "Adding the null check you should have written" - **Tired PM** — "Updating 'On Track' to 'On Track*'" - **Designer-engineer drowning in design tokens** — "Migrating from semantic tokens to semantic tokens" - **CTO hiding tech debt with toxic positivity** — "Unifying our two billing systems by adding a third" 261 phrases, all unique. Co-authored-by: Automaker <automaker@localhost> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 2 minutes and 52 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (11)
WalkthroughThis PR updates project documentation and version metadata across the monorepo. The README is expanded to reference a new architectural divergence document detailing how the fork diverges from upstream. Package versions are bumped uniformly, the CLI's witty loading phrases are refreshed, and sandbox image URIs are aligned with new version tags. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mabry1985
enabled auto-merge
April 26, 2026 08:24
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
3-23:⚠️ Potential issue | 🟠 MajorKeep the root release artifacts on the same version line.
This promotion is described as the
0.26.10release, but the root manifest already jumps to0.26.11and points the sandbox image at:0.26.11while the workspace packages in this PR are still0.26.10. That makes the release chain ambiguous and can leave installs pointing at an image tag this promotion does not publish.Suggested fix
- "version": "0.26.11", + "version": "0.26.10", ... - "sandboxImageUri": "ghcr.io/qwenlm/qwen-code:0.26.11" + "sandboxImageUri": "ghcr.io/qwenlm/qwen-code:0.26.10"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 3 - 23, The root package.json version and sandbox image tag are ahead of the workspace package versions; either align everything to 0.26.10 or bump the workspace packages to 0.26.11 — specifically update the "version" field and the "config.sandboxImageUri" tag in package.json to match the workspace package versions, or update the versions in the packages/* workspace manifests to 0.26.11 so all release artifacts use the same version line.
🧹 Nitpick comments (2)
docs/architecture/divergence-from-upstream.md (2)
473-473: Optional: hyphenate the compound modifier.As per the static analysis hint, "conventional-commit driven" should be hyphenated when used as a compound modifier before a noun: "conventional-commit-driven bump".
✏️ Suggested fix
-- `scripts/determine-bump.js`, `scripts/rewrite-release-notes.mjs` — - conventional-commit driven bump + notes rewrite. + conventional-commit-driven bump + notes rewrite.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/architecture/divergence-from-upstream.md` at line 473, Change the phrase "conventional-commit driven bump + notes rewrite" to use a hyphenated compound modifier: "conventional-commit-driven bump + notes rewrite"; locate and update the exact string in docs/architecture/divergence-from-upstream.md so the compound modifier before "bump" is hyphenated.
1-609: Consider a strategy for maintaining file/line references.The document includes numerous specific file and line number references (e.g.,
packages/cli/package.json:17,packages/core/src/utils/partUtils.ts:14-26). These are helpful for readers but will drift as the codebase evolves.Consider one of these approaches:
- Version-pin the references: Add a note that all references are accurate as of the snapshot date (April 2026) but may drift.
- Periodic review task: Add a maintenance reminder to verify references quarterly or after major refactors.
- Automated validation: Add a CI check that verifies referenced files exist (though exact line numbers would still drift).
Option 1 is simplest and may be sufficient given the document's "snapshot at time of writing" framing (line 11).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/architecture/divergence-from-upstream.md` around lines 1 - 609, The doc embeds many file:line references that will drift; add a clear maintenance strategy by (a) prefixing the top snapshot block with a single-note stating "All file:line references are accurate as of April 2026" (use the existing Snapshot header), (b) add a short "Reference maintenance" subsection near the end recommending quarterly review or after large refactors, and (c) mention optional CI validation as a follow-up; reference examples like packages/cli/package.json:17 and packages/core/src/utils/partUtils.ts:14-26 so reviewers can locate where to place the one-line snapshot-note and the new maintenance subsection.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/cli/package.json`:
- Around line 39-40: The sandboxImageUri in package.json is pinned to a newer
image tag (0.26.11) than this package release (0.26.10); change it so the CLI
won’t try to pull an unavailable tag—either set "config.sandboxImageUri" to the
same tag as this package's version (0.26.10) or make it dynamic by referencing
the package version at runtime (so the value used by
packages/cli/src/utils/package.ts and packages/cli/src/config/sandboxConfig.ts
matches the package.json "version"); ensure the chosen approach updates the
config value consistently so sandbox mode never requests a tag newer than the
shipped package.
---
Outside diff comments:
In `@package.json`:
- Around line 3-23: The root package.json version and sandbox image tag are
ahead of the workspace package versions; either align everything to 0.26.10 or
bump the workspace packages to 0.26.11 — specifically update the "version" field
and the "config.sandboxImageUri" tag in package.json to match the workspace
package versions, or update the versions in the packages/* workspace manifests
to 0.26.11 so all release artifacts use the same version line.
---
Nitpick comments:
In `@docs/architecture/divergence-from-upstream.md`:
- Line 473: Change the phrase "conventional-commit driven bump + notes rewrite"
to use a hyphenated compound modifier: "conventional-commit-driven bump + notes
rewrite"; locate and update the exact string in
docs/architecture/divergence-from-upstream.md so the compound modifier before
"bump" is hyphenated.
- Around line 1-609: The doc embeds many file:line references that will drift;
add a clear maintenance strategy by (a) prefixing the top snapshot block with a
single-note stating "All file:line references are accurate as of April 2026"
(use the existing Snapshot header), (b) add a short "Reference maintenance"
subsection near the end recommending quarterly review or after large refactors,
and (c) mention optional CI validation as a follow-up; reference examples like
packages/cli/package.json:17 and packages/core/src/utils/partUtils.ts:14-26 so
reviewers can locate where to place the one-line snapshot-note and the new
maintenance subsection.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8a3e1be5-de01-4a86-9d04-705591fc8b0a
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (9)
README.mddocs/architecture/divergence-from-upstream.mdpackage.jsonpackages/cli/package.jsonpackages/cli/src/i18n/locales/en.jspackages/core/package.jsonpackages/test-utils/package.jsonpackages/web-templates/package.jsonpackages/webui/package.json
…#125) Backport of the core foundation pieces from upstream #3591 (TUI flicker foundation fixes). Two interventions on stdout, both no-op outside a TTY or under a screen reader: 1. terminalRedrawOptimizer (from upstream #3381 → #3591): wraps stdout.write to collapse Ink's per-line {ERASE_LINE, CURSOR_UP_ONE} sequences into a single {CURSOR_UP_N, erase_at_each, CURSOR_UP_N, CURSOR_LEFT}. Eliminates the scrollback-bouncing during streaming renders. Bypass via PROTO_LEGACY_ERASE_LINES=1. 2. synchronizedOutput (from #3591): wraps each render frame in BSU/ESU escape codes (\\e[?2026h / \\e[?2026l) on supporting terminals (Kitty, WezTerm, iTerm) so Ink frames are committed atomically. Terminal allowlist with auto-detect; opt-out via PROTO_DISABLE_SYNCHRONIZED_OUTPUT=1, force on via PROTO_FORCE_SYNCHRONIZED_OUTPUT=1. Both installed in startInteractiveUI() before the Ink render call; both restored in the registerCleanup callback. Deferred from upstream #3591 (too entangled with our fork's useGeminiStream.ts / ToolMessage.tsx divergence; revisit later): - main-stream event buffering with flush timer - tool output pre-slicing by visual height - shell soft-wrap-only rerender suppression The two installed pieces cover the user-visible streaming flicker case directly; the deferred pieces are about huge-tool-output and narrow-terminal soft-wrap edge cases. Co-authored-by: Automaker <automaker@localhost> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes everything that's accumulated on dev since the last main promotion (#118):
docs/architecture/divergence-from-upstream.md)Also includes the v0.26.6 → v0.26.10 release-bump chain that auto-release.yml has been opening on dev after each backport.
After merge, auto-release fires once with v0.26.10 already on main.
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation
Chores