Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove org-modern faces? #48

Closed
minad opened this issue Nov 5, 2024 · 2 comments
Closed

Remove org-modern faces? #48

minad opened this issue Nov 5, 2024 · 2 comments

Comments

@minad
Copy link

minad commented Nov 5, 2024

Hi Prot,

this is a little bit of an odd request. I would like to ask to remove support for Org-modern from Ef, since the theme faces seem to interfere with Org-modern and create scaling issues. I tried to design Org-modern such that themes do not have to override its settings. My perspective is also that Org-modern is somehow a "theme" itself, even if not in the classical Emacs sense.

Alternatively maybe only adjust the colors, but not any other settings (weights, fonts, sizes)? By not adjusting weights and sizes, the overall layout predictability will be simplified, since there are too many cooks which otherwise participate (Org-modern, the font family, line spacing, ..., and the theme) and Org-modern is already a difficult package to configure for users to get the desired layout. Overriding colors in themes should be fine however and not lead to problems I guess.

Thanks!

Daniel

protesilaos added a commit that referenced this issue Nov 6, 2024
We do the same with the modus-themes.

Thanks to Daniel Mendler, the author of org-modern, for bringing this
matter to my attention. This was done in issue 48:
<#48>.
@protesilaos
Copy link
Owner

protesilaos commented Nov 6, 2024 via email

@minad
Copy link
Author

minad commented Nov 6, 2024

Thanks!

@minad minad closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants