You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this is a little bit of an odd request. I would like to ask to remove support for Org-modern from Ef, since the theme faces seem to interfere with Org-modern and create scaling issues. I tried to design Org-modern such that themes do not have to override its settings. My perspective is also that Org-modern is somehow a "theme" itself, even if not in the classical Emacs sense.
Alternatively maybe only adjust the colors, but not any other settings (weights, fonts, sizes)? By not adjusting weights and sizes, the overall layout predictability will be simplified, since there are too many cooks which otherwise participate (Org-modern, the font family, line spacing, ..., and the theme) and Org-modern is already a difficult package to configure for users to get the desired layout. Overriding colors in themes should be fine however and not lead to problems I guess.
Thanks!
Daniel
The text was updated successfully, but these errors were encountered:
We do the same with the modus-themes.
Thanks to Daniel Mendler, the author of org-modern, for bringing this
matter to my attention. This was done in issue 48:
<#48>.
From: Daniel Mendler ***@***.***>
Date: Tue, 5 Nov 2024 03:41:29 -0800
Hi Prot,
Hello Daniel,
this is a little bit of an odd request. I would like to ask to remove
support for Org-modern from Ef
[... 18 lines elided]
I thought we were doing this already... It is how we have it with the
Modus themes. I just pushed the change to remove them. We do not want to
break anything.
All the best,
Prot
Hi Prot,
this is a little bit of an odd request. I would like to ask to remove support for Org-modern from Ef, since the theme faces seem to interfere with Org-modern and create scaling issues. I tried to design Org-modern such that themes do not have to override its settings. My perspective is also that Org-modern is somehow a "theme" itself, even if not in the classical Emacs sense.
Alternatively maybe only adjust the colors, but not any other settings (weights, fonts, sizes)? By not adjusting weights and sizes, the overall layout predictability will be simplified, since there are too many cooks which otherwise participate (Org-modern, the font family, line spacing, ..., and the theme) and Org-modern is already a difficult package to configure for users to get the desired layout. Overriding colors in themes should be fine however and not lead to problems I guess.
Thanks!
Daniel
The text was updated successfully, but these errors were encountered: