External decryption config bindings #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristekdatum
requested review from
argmarco-tkd,
avalerio-tkd and
sofia-tekdatum
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
cristekdatum
commented
Aug 10, 2025
cristekdatum
force-pushed
the
external_decryption_config_bindings
branch
from
9973358 to
53323b9
Compare
Collaborator
|
It's very confusing to try to do this review with all the pending changes for the other 2 PRs. Please rebase properly and send out for review again showing only the diffs relevant to this PR. Thanks |
This was
linked to
issues
Aug 11, 2025
… external_decryption_config_bindings
cristekdatum
force-pushed
the
external_decryption_config_bindings
branch
9 times, most recently
from
518a9bb to
7e44f69
Compare
cristekdatum
force-pushed
the
external_decryption_config_bindings
branch
from
7e44f69 to
24f7f2a
Compare
… external_decryption_config_bindings
cristekdatum
force-pushed
the
external_decryption_config_bindings
branch
4 times, most recently
from
f8e7554 to
6674986
Compare
cristekdatum
force-pushed
the
external_decryption_config_bindings
branch
from
6674986 to
457af33
Compare
sofia-tekdatum
approved these changes
Aug 13, 2025
| for cipher_name, inner_dict in value.items(): | ||
| cipher_enum = cipher_from_name(cipher_name) | ||
| if not isinstance(inner_dict, dict): | ||
| raise TypeError(f"Inner value for cipher {cipher_name!r} must be a dict") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the changes for #31 and the task #33 there are the new ExternalDecryptionConfiguration bindings