Js es6 #1
Open
Js es6 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"cid", a unique id assigned to all objects created by FlipClock
…for translating strings in FlipClock
…instead of using jQuery and strings
…r passing the object to child classes as a property
…of using strings and jQuery
…f using callbacks in properties
…f using callbacks in properties
…The flip() method was getting triggered twice.
… the number of seconds. Should never display 60.
…aceValue() on the FlipClock.Factory class
…aceValue() on the Face class
…es should be automatically added to the clock
- Updated all the primary examples and tested to make sure they work - Fixed some issues with counters - Added a few new examples and deleted some redundant ones - Fixed some issues with languages - Added ability to pass custon language dictionary object options used to instantiate a FlipClock instance
- Added jsdoc code blocks to most methods/classes. Still need proofed, with better examples. But the core is there. Docs are auto generated on new builds. - Will use new /docs directory to replace flipclockjs.com for v1. Still need to theme and finish the docs, but this commit represents a large chunk
- Updated another round of code comments - Updated /docs - Reorganized docs blocks for better readability in the /docs TODO: Theme the /docs with custom templates and make that what will become the flipclock website, or at least the doc portion if the jsdocs isn’t flexible enough
- Updated jsdoc with new flipclock theme. Site can now be entirely generated by jsdocs. - Docs are deployable and viewable as local files
- Finished porting all the existing examples into the new docs - Added page to tell how others can contribute and create new examples for the repo
- Fixed various lint warnings - Fixed issue with using constructor.name, replace with new static method for each class. objectivehtml#375
Great bug to get fixed. No backface visibility used, and the px offset is gone which was caused by a chrome bug. https://stackoverflow.com/questions/24854640/strange-pixel-shifting-jumping-in-firefox-with-css-transitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.