Add tasks details #61

proszewskip · 2018-12-13T20:21:10Z

No description provided.

Gelio

The code looks good to me, with some exceptions 😄 Take a look at the comments

frontend/pages/distributed-tasks/details.tsx

frontend/src/features/distributed-nodes/table/table.tsx

frontend/src/features/distributed-tasks/details/details.tsx

frontend/src/features/distributed-tasks/details/types.ts

frontend/src/features/subtasks/table/table/subtask-status-cell.tsx

frontend/src/features/subtasks/table/table/subtask-status-filter.tsx

frontend/src/features/subtasks/table/table/table.tsx

frontend/src/product-specific/sidebar/authenticated-sidebar-menu-items.ts

proszewskip · 2018-12-14T11:34:21Z

@Gelio I have updated this PR, please review again.

frontend/src/features/distributed-task-definitions/details/details.tsx

frontend/src/features/distributed-task-definitions/details/types.ts

frontend/src/features/distributed-tasks/details/details.tsx

frontend/src/features/distributed-tasks/details/format-distributed-task-status.tsx

frontend/src/features/distributed-tasks/details/get-details-grid.tsx

frontend/src/features/subtasks/table/table/subtask-status-cell.tsx

frontend/src/features/subtasks/table/table/table.tsx

Gelio · 2018-12-15T10:12:12Z

Detale dla DistributedTask

frontend/src/features/distributed-tasks/details/get-details-grid.tsx

Gelio · 2018-12-15T11:37:54Z

I noticed there is an underline on the Download buttons on the details page.

Let's try to remove it to achieve the same visual style as other buttons. My suggestions to fix this is to add a class in src/styles.css:

a.without-underline {
  text-decoration: none;
}

and apply it on the a tag:

<a href={inputDataUrl} download={true} className="without-underline">

This goes for both buttons.

Also, in the same place, let's add a Pane that wraps the a tag and apply the marginRight on it, instead of the button inside the a tag. When the margin is applied inside the button, when the element is focused via the keyboard, it looks weird:

Gelio

Some more changes to go 😄

frontend/src/features/distributed-task-definitions/details/details.tsx

frontend/src/features/distributed-tasks/details/details.tsx

Gelio · 2018-12-15T19:41:41Z

Server/Models/Subtask.cs

        [Attr("sequence-number", isImmutable: true)]
        public int SequenceNumber { get; set; }

+        [Attr("distributed-task-id")]


I reckon we should add isImmutable: true to this attribute

Gelio · 2018-12-15T19:42:53Z

frontend/pages/distributed-tasks/details.tsx

+class DetailsPage extends PureComponent<
+  DistributedTaskDetailsProps & WithRouterProps
+> {
+  public static getInitialProps: GetInitialPropsFn = ({ query }) => {


Let's move the implementation of getInitialProps to inside src/features, similar to how other pages implement getInitialProps

This way all the logic regarding a feature is in one directory instead of in two

Gelio · 2018-12-15T19:48:41Z

frontend/src/features/distributed-tasks/details/details.tsx

+        </Pane>
+
+        <Pane marginRight={minorScale(2)} display="inline">
+          <a href={resultsUrl} download={true} className="without-underline">


Let's only pass the href when taskDone === true. Currently even though the button is disabled, the user may still click it and be redirected to an API endpoint for downloading the results.

<a href={taskDone ? resultsUrl : null} ...

Gelio · 2018-12-15T20:31:28Z

Welp, now there are merge conflicts 😢 Could you apply the fixes you made to table-example.tsx to where it is now moved, i.e. src\features\distributed-task-definitions\table\table.tsx? (remove a custom implementation of TextCell and import the one from components/data-table/cells/text-cell?

Add tasks details

proszewskip added the frontend label Dec 13, 2018

proszewskip self-assigned this Dec 13, 2018

proszewskip requested a review from Gelio December 13, 2018 20:21

Gelio requested changes Dec 13, 2018

View reviewed changes

Gelio requested changes Dec 14, 2018

View reviewed changes

Gelio reviewed Dec 15, 2018

View reviewed changes

frontend/src/features/distributed-tasks/details/get-details-grid.tsx Outdated Show resolved Hide resolved

Gelio requested changes Dec 15, 2018

View reviewed changes

Gelio approved these changes Dec 15, 2018

View reviewed changes

proszewskip added 17 commits December 15, 2018 21:47

[frontend] add distributed task model

5775877

[frontend] add distributed tasks details

447c5ad

[frontend] add subtask model

4648dab

[frontend] add subtasks table

5a7d65d

[frontend] add distributed task details page

5b2da70

[frontend] remove unused file

1a9080e

[frontend] add subtasks table to details page

aa5bab3

[frontend] fix wrong header name

acb1064

[frontend] use dictionary for status mapping

8655b92

[server] enable filtering by distributed task id

15000e7

[frontend] extract TextCell

9b840e3

[frontend] filter subtasks table by parent task id

ee57649

[frontend] add default option for subtask status filtering

fb325a4

[frontend] separate render into multiple functions

4f040da

[frontend] move button clicks handlers to details components

e9e2c2e

[frontend] fix typo

70092ca

[frontend] reduce scope of kitsu

aa20ae4

proszewskip added 10 commits December 15, 2018 21:48

[frontend] disable delete button when request is pending

5fa8e0a

[frontend] simplify empty array creation

163f72e

[frontend] use enum as dictionary key

bf6efa2

[frontend] convert function to stateless component

cd59f9c

[frontend] remove unnecessary leading space

3401b83

[frontend] disable delete button when request is pending

d952b1c

[frontend] rename variable

0ff87bb

[server] add isImmutable to distributed task id

fca721e

[frontend] move get initial props to features

3acf18f

[frontend] remove download url when result is not ready

03388e8

proszewskip force-pushed the add-tasks-details branch from 4242432 to 03388e8 Compare December 15, 2018 20:49

[frontend] merge imports

deb2060

Gelio merged commit 8f04fde into master Dec 15, 2018

Gelio deleted the add-tasks-details branch December 15, 2018 20:57

proszewskip pushed a commit that referenced this pull request Feb 23, 2020

Merge pull request #61 from proszewskip/add-tasks-details

5ce4de0

Add tasks details

Add tasks details #61

Add tasks details #61

Uh oh!

Conversation

proszewskip commented Dec 13, 2018

Uh oh!

Gelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

proszewskip commented Dec 14, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Gelio commented Dec 15, 2018

Uh oh!

Uh oh!

Gelio commented Dec 15, 2018

Uh oh!

Gelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Gelio Dec 15, 2018

Choose a reason for hiding this comment

Uh oh!

Gelio Dec 15, 2018

Choose a reason for hiding this comment

Uh oh!

Gelio Dec 15, 2018

Choose a reason for hiding this comment

Uh oh!

Gelio Dec 15, 2018

Choose a reason for hiding this comment

Uh oh!

Gelio commented Dec 15, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants