chore(ci): drop windows-latest from test matrix#3
Merged
prospapledge88 merged 1 commit intodevfrom Apr 14, 2026
Merged
Conversation
We develop exclusively on macOS. Windows was an untested platform in the matrix, going red on the env-integration test cherry-picked from upstream in d02dd3a (subprocessEnv.PATH vs Path casing on Windows). Rather than pull upstream's Windows-casing test fix (6a6740a / coleam00#1160) for a platform we cannot verify locally, scope CI to what we actually develop against. The release workflow still publishes archon-windows-x64.exe for user convenience — binary builds remain, only the test job loses its Windows matrix entry. If Windows user demand surfaces, reintroduce windows-latest to the matrix AND cherry-pick upstream coleam00#1160 together. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ubuntu-latestbehavior for the affected tests).Context
Our fork cherry-picked the env-integration tests in
d02dd3a7but not the cross-platform follow-up (upstream coleam00#1160 /6a6740af), so Windows CI has been red on assertions likeexpect(subprocessEnv.PATH).toBeDefined()— on Windows the spread-object key isPath, notPATH.Since we develop exclusively on macOS and do not test-validate Windows locally, picking up the upstream fix adds churn for behavior we cannot verify. Scoping the test job to
ubuntu-latestreflects what we actually support. The release workflow'sbun-windows-x64binary build is unaffected — users who want Windows binaries still get them.Test plan
.github/workflows/test.ymldiff reviewed locallyubuntu-latesttest job +docker-build)windows-latesttest matrix entryReversal path
If Windows user demand surfaces, re-add
windows-latestto the matrix in one commit AND cherry-pick upstream6a6740afin a second commit together — they must land as a pair.🤖 Generated with Claude Code