Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix-ci-nigtly] #285

Merged
merged 3 commits into from
Jan 2, 2023
Merged

[fix-ci-nigtly] #285

merged 3 commits into from
Jan 2, 2023

Conversation

rex-remind101
Copy link
Collaborator

@rex-remind101 rex-remind101 commented Dec 19, 2022

ci was broken on nightly this series of fixes should correct it

  • dependencies.x86 was bumped to latest current version. x86 crate does not advertise an MSRV, but this was just broken on even our MSRV because the old x86 version was using a macro removed from rust, so bumping to latest seems fair.
  • the calculation for the arbitrary impl of Layout was using a max_size that was too large and overflowing Layout. this has been fixed.
  • test for arbitrary AllocError was referering to AllocErr which does not exist, this was fixed.
  • NoneError has been removed from rust so it was subsequently removed from proptest. It was blocking compilation. evidence: cannot find value NoneError in module std::option  rust-lang/rust#85614
  • try_reserve is stable so removed from unstable features
  • try_trait has been changed to try_trait_v2 so that was fixed in Cargo.toml.

…orrect it

* dependencies.x86 was bumped to latest current version. x86 crate
  does not advertise an MSRV, but this was just broken on even our
  MSRV because the old x86 version was using a macro removed from
  rust, so bumping to latest seems fair.
* the calculation for the arbitrary impl of Layout was using a
  max_size that was too large and overflowing Layout. this has
  been fixed.
* test for arbitrary AllocError was referring to AllocErr which
  does not exist, this was fixed.
* NoneError has been removed from rust so it was subsequently
  removed from proptest. It was blocking compilation.
  evidence:
  rust-lang/rust#85614
* try_reserve is stable so removed from unstable features
* try_trait has been changed to try_trait_v2 so that was fixed
  in Cargo.toml.
Copy link
Member

@cameron1024 cameron1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for looking into this 😁

@rex-remind101 rex-remind101 force-pushed the fix-ci-nightly branch 3 times, most recently from 3ab6eac to b6212c9 Compare December 19, 2022 20:30
@matusf
Copy link

matusf commented Dec 20, 2022

Hi, just fyi, this PR can close also #266

@rex-remind101
Copy link
Collaborator Author

fyi, we're still trying to piece together why this last compiletest is failing.

@rex-remind101 rex-remind101 merged commit 932c1d6 into master Jan 2, 2023
@rex-remind101 rex-remind101 deleted the fix-ci-nightly branch January 2, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants