Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tweak numbers to feel more like overcooked #5

Merged
merged 2 commits into from
Feb 4, 2023

Conversation

Crylion
Copy link
Contributor

@Crylion Crylion commented Feb 1, 2023

Hey there :)
Just a suggested tweaking of your values to make it feel more like overcooked (in my opinion).
I'm really glad you made this mod, since my partner and I recently started playing PlateUp after an obsession with Overcooked, and especially my partner really missed the dash, because it was so ingrained in their muscle memory from the other game x)

But after trying your mod, it felt to me like there could be some work done to make it feel more like the dash in overcooked. For one thing, you can't hold the button down in overcooked, you have to press it repeatedly, and it has a slightly longer cooldown, but it basically catapults you forward when you do so.
So I changed your event handler to only accept single button presses and changed the speed boost to be one big boost that jumps you ahead, but stops again very shortly.

I even tried to find a way to actually throw the player forward (even when standing, like in overcooked), but I could not figure out how. You can basically teleport the player, but I couldn't find a way to force a forward movement.

@propstg
Copy link
Owner

propstg commented Feb 1, 2023

Hey, I'll have to give this a try later tonight, thanks! My own overcooked muscle memory is the reason this exists, so I appreciate the effort to tune it to make it more like overcooked. :)

When I moved to this control system, to correctly handle the ping button even if remapped by the user (previously had hardcoded buttons), I unfortunately experienced delayed and missed dashes as the client, when just checking for Pressed. I reluctantly made the compromise to check everything (and allow holding), so that it would at least work consistently whether you were the host or the client.

I'm not sure if the underlying issue has been fixed in the game by now, but just wondering if you had a chance to see if that was an issue after changing this?

Throwing the player forward and causing a bigger cloud of dust would both be very cool.

@Crylion
Copy link
Contributor Author

Crylion commented Feb 1, 2023

Thanks for the quick response :)
I kinda figured that the checks for all kinds of button presses and holds had to be some kind of workaround, that makes sense. Unfortunately, I only tested it in singleplayer for now and tomorrow I'll play it again with my partner to test it in actual gameplay. But that's only in couch coop, not online. I'll admit, that I didn't even think about problems with online play 🤔

Yeah the cloud of dust would be a very nice touch 😁 I'm too new to modding and Unity stuff to pull that off x)

@propstg
Copy link
Owner

propstg commented Feb 2, 2023

I was finally able to take a look at this, solo. In both PlateUp! and Overcooked 2 it looks like the distance dashed is about the same, now. Roughly 4 squares, eyeballing it.

The cooldown feels a little long, though? In overcooked, you can really spam the button and have almost no downtime between dashes, and it takes about ~1.4 seconds to go 13 spaces (with some admittedly not great solo stop watch work) when spamming the dash button. In plateup with your speed + cooldown changes, it takes me around ~1.8 seconds. With a 0.9f cooldown, it's closer to ~1.4 seconds.

What do you think about something closer to a 0.9f cooldown?

I'll give it a try in a networked game tomorrow and see if the client still registers button presses inconsistently. If it does, I think a menu option might make sense to switch between what you have and the current functionality. So if you only play solo, couch multiplayer, or host, you can have one press = one dash, but if you play online and want it to behave consistently wherever you are, you can have the current hacky functionality.

I'm too new to modding and Unity stuff to pull that off x)

Same. :)

@Crylion
Copy link
Contributor Author

Crylion commented Feb 2, 2023

Now that's some attention to detail 😁
I was trying to be on the safe side with the cooldown, to not make it feel too spammable, but my comparison with Overcooked 2 was mostly eyeballing as well. I'll gladly try out 0.9f for the cooldown.

And the menu option sounds like a great way to allow both, I should be able to add that :)
When I find the time, I'll try how the current dash feels when it is auto-repeated by holding down the button ^^

@propstg
Copy link
Owner

propstg commented Feb 4, 2023

Unfortunately it does seem like the dashing behaves very inconsistently when you're the client, so I think a menu option would be nice. If you don't want to add it, I can merge your changes as is and add it after. It's up to you. :)

@Crylion
Copy link
Contributor Author

Crylion commented Feb 4, 2023

That's a shame :/
I'll do it this weekend, or at least try to 😁

@propstg
Copy link
Owner

propstg commented Feb 4, 2023

Looks good! Thanks for making the initial change and being open to discussing/changing it. :)

I'm going to merge this and probably release it later today.

@propstg propstg merged commit 54f24f5 into propstg:master Feb 4, 2023
@Crylion Crylion deleted the feature/overcoookedTweak branch February 4, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants