-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Add AsyncComputed #77
Changes from 7 commits
10a584e
d0d40bd
3f3d290
590a616
09aed79
4a00ab9
fad1689
2cc2b16
124f6a5
4d59565
7142b4f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -80,7 +80,7 @@ | |
}, | ||
"packageManager": "[email protected]", | ||
"volta": { | ||
"node": "20.12.2", | ||
"node": "22.0.0", | ||
"pnpm": "9.0.5" | ||
} | ||
} |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The inline docs here are wonderful! |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,206 @@ | ||
import { Signal } from "signal-polyfill"; | ||
|
||
export type AsyncComputedStatus = "initial" | "pending" | "complete" | "error"; | ||
|
||
export interface AsyncComputedOptions<T> { | ||
/** | ||
* The initial value of the AsyncComputed. | ||
*/ | ||
initialValue?: T; | ||
} | ||
|
||
/** | ||
* A signal-like object that represents an asynchronous computation. | ||
* | ||
* AsyncComputed takes a compute function that performs an asynchronous | ||
* computation and runs it inside a computed signal, while tracking the status of | ||
* the computation, including its most recent completion value and error. | ||
* | ||
* Compute functions are run when the `value`, `error`, or `complete` properties | ||
* are read, or when `get()` or `run()` are called, and are re-run when any | ||
* signals that they read change. | ||
* | ||
* If a new run of the compute function is started before the previous run has | ||
* completed, the previous run will have its AbortSignal aborted, and the | ||
* result of the previous run will be ignored. | ||
*/ | ||
export class AsyncComputed<T> { | ||
// Whether we have been notified of a pending update from the watcher. This is | ||
// set synchronously when any dependencies of the compute function change. | ||
#isNotified = false; | ||
#status = new Signal.State<AsyncComputedStatus>("initial"); | ||
|
||
/** | ||
* The current status of the AsyncComputed, which is one of 'initial', | ||
* 'pending', 'complete', or 'error'. | ||
* | ||
* The status will be 'initial' until the compute function is first run. | ||
* | ||
* The status will be 'pending' while the compute function is running. If the | ||
* status is 'pending', the `value` and `error` properties will be the result | ||
* of the previous run of the compute function. | ||
* | ||
* The status will be 'complete' when the compute function has completed | ||
* successfully. If the status is 'complete', the `value` property will be the | ||
* result of the previous run of the compute function and the `error` property | ||
* will be `undefined`. | ||
* | ||
* The status will be 'error' when the compute function has completed with an | ||
* error. If the status is 'error', the `error` property will be the error | ||
* that was thrown by the previous run of the compute function and the `value` | ||
* property will be `undefined`. | ||
* | ||
* This value is read from a signal, so any signals that read it will be | ||
* tracked as dependents of it. | ||
*/ | ||
get status() { | ||
// Unconditionally read the status signal to ensure that any signals that | ||
// read it are tracked as dependents. | ||
const currentState = this.#status.get(); | ||
return this.#isNotified ? "pending" : currentState; | ||
} | ||
|
||
/** | ||
* The last value that the compute function resolved with, or `undefined` if | ||
* the last run of the compute function threw an error, or if the compute | ||
* function has not yet been run. | ||
* | ||
* This value is read from a signal, so any signals that read it will be | ||
* tracked as dependents of it. | ||
*/ | ||
#value: Signal.State<T | undefined>; | ||
get value() { | ||
this.run(); | ||
return this.#value.get(); | ||
} | ||
|
||
/** | ||
* The last error that the compute function threw, or `undefined` if the last | ||
* run of the compute function resolved successfully, or if the compute | ||
* function has not yet been run. | ||
* | ||
* This value is read from a signal, so any signals that read it will be | ||
* tracked as dependents of it. | ||
*/ | ||
#error = new Signal.State<unknown | undefined>(undefined); | ||
justinfagnani marked this conversation as resolved.
Show resolved
Hide resolved
|
||
get error() { | ||
this.run(); | ||
return this.#error.get(); | ||
} | ||
|
||
#deferred = new Signal.State<PromiseWithResolvers<T> | undefined>(undefined); | ||
justinfagnani marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
/** | ||
* A promise that resolves when the compute function has completed, or rejects | ||
* if the compute function throws an error. | ||
* | ||
* If a new run of the compute function is started before the previous run has | ||
* completed, the promise will resolve with the result of the new run. | ||
*/ | ||
get complete(): Promise<T> { | ||
this.run(); | ||
// run() will have created a new deferred if needed. | ||
return this.#deferred.get()!.promise; | ||
} | ||
|
||
#computed: Signal.Computed<void>; | ||
|
||
#watcher: Signal.subtle.Watcher; | ||
|
||
// A unique ID for the current run. This is used to ensure that runs that have | ||
// been preempted by a new run do not update state or resolve the deferred | ||
// with the wrong result. | ||
#currentRunId = 0; | ||
|
||
#currentAbortController?: AbortController; | ||
|
||
/** | ||
* Creates a new AsyncComputed signal. | ||
* | ||
* @param fn The function that performs the asynchronous computation. Any | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While there can't be fully automatic tracking for any async signal reads in the computation, it could be supported via an API. Consider:
The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I definitely considered that - it's something we could add later. It's also debatable whether the current behavior is better than a separately tracked sync function, similar to how |
||
* signals read synchronously - that is, before the first await - will be | ||
* tracked as dependencies of the AsyncComputed, and cause the function to | ||
* re-run when they change. | ||
* | ||
* @param options.initialValue The initial value of the AsyncComputed. | ||
*/ | ||
constructor( | ||
fn: (signal: AbortSignal) => Promise<T>, | ||
justinfagnani marked this conversation as resolved.
Show resolved
Hide resolved
|
||
options?: AsyncComputedOptions<T>, | ||
) { | ||
this.#value = new Signal.State(options?.initialValue); | ||
this.#computed = new Signal.Computed(() => { | ||
const runId = ++this.#currentRunId; | ||
// Untrack reading the status signal to avoid triggering the computed when | ||
// the status changes. | ||
const status = Signal.subtle.untrack(() => this.#status.get()); | ||
|
||
// If we're not already pending, create a new deferred to track the | ||
// completion of the run. | ||
if (status !== "pending") { | ||
this.#deferred.set(Promise.withResolvers()); | ||
} | ||
this.#isNotified = false; | ||
this.#status.set("pending"); | ||
|
||
this.#currentAbortController?.abort(); | ||
this.#currentAbortController = new AbortController(); | ||
|
||
fn(this.#currentAbortController.signal).then( | ||
(result) => { | ||
// If we've been preempted by a new run, don't update the status or | ||
// resolve the deferred. | ||
if (runId !== this.#currentRunId) { | ||
return; | ||
} | ||
this.#status.set("complete"); | ||
this.#value.set(result); | ||
this.#error.set(undefined); | ||
this.#deferred.get()!.resolve(result); | ||
}, | ||
(error) => { | ||
// If we've been preempted by a new run, don't update the status or | ||
// resolve the deferred. | ||
if (runId !== this.#currentRunId) { | ||
return; | ||
} | ||
this.#status.set("error"); | ||
this.#error.set(error); | ||
this.#value.set(undefined); | ||
this.#deferred.get()!.reject(error); | ||
}, | ||
); | ||
}); | ||
this.#watcher = new Signal.subtle.Watcher(() => { | ||
this.#isNotified = true; | ||
this.#watcher.watch(); | ||
}); | ||
this.#watcher.watch(this.#computed); | ||
} | ||
|
||
/** | ||
* Returns the last value that the compute function resolved with, or | ||
* `undefined` if the compute function has not yet been run. | ||
* | ||
* @throws The last error that the compute function threw, is the last run of | ||
* the compute function threw an error. | ||
*/ | ||
get() { | ||
const status = this.status; | ||
if ( | ||
status === "error" || | ||
(status === "pending" && this.error !== undefined) | ||
) { | ||
throw this.error; | ||
} | ||
return this.value; | ||
} | ||
|
||
/** | ||
* Runs the compute function if it is not already running and its dependencies | ||
* have changed. | ||
*/ | ||
run() { | ||
this.#computed.get(); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why specify this? 🤔
we could add an
.nvmrc
or.node-version
, perhaps?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To get
Promise.withResolvers()
.It's of course only a few lines to do what
withResolvers()
does, butwithResolvers()
is so nice and I figured this library is pretty cutting edge, so...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes, I mean, setting node 22 is great!
Will also need to update: