Continuous Integration

[oxr463]

Tools

• Clippy, (Docs: https://rust-lang.github.io/rust-clippy).
• rustfmt.
  • Pre-commit hook
  • Run in CI, (Travis Example: https://github.com/rust-lang/rustfmt#checking-style-on-a-ci-server).
• Cargo Tests
  • Unit Tests

Also, per conversation with @jyn514,

run clippy before compiling, otherwise it won't output anything, it's an ongoing bug.

[jyn514]

Link to original clippy issue: rust-lang/rust-clippy#2604

[oxr463]

• Update gcc dependency

[build-dependencies]
-gcc = { git = "https://github.com/vincenthage/gcc-rs", branch = "master" }
+gcc = { git = "https://github.com/alexcrichton/cc-rs", branch = "master" }

• Switch to nightly channel

rust:
- nightly

• Fix formatting, cargo fmt --all.

[jyn514]

Just so you know, cargo fmt --all && git diff --numstat | awk '{print $1 + $2}' | paste -sd+ | bc shows 800 modified lines, which is a bit much to review by hand. Maybe only check formatting for modified files in each commit?

[oxr463]

But won't running cargo fmt --all, automatically fix the formatting?

How would I only check the formatting for modified files?

[jyn514]

Hmm... maybe something like this? git status --porcelain | sed 's/^...//' | grep '\.rs$' | xargs cargo fmt -v --, see https://stackoverflow.com/questions/5237605/how-can-i-run-git-status-and-just-get-the-filenames#5238537

[jyn514]

Also the existing unit tests aren't passing, I'm taking a look at that now

[oxr463]

Closing per #12