Remove erroneous note about _default_background_color override beha…

…vior on iOS (beeware#3125) Clarified why we're capturing `_default_background_color`, and that it's not overridable. --------- Co-authored-by: Russell Keith-Magee <[email protected]>
proneon267 · Jan 26, 2025 · 78d3e75 · 78d3e75
1 parent 25891f0
commit 78d3e75
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/changes/3125.misc.rst b/changes/3125.misc.rst
@@ -0,0 +1 @@
+On iOS, an erroneous note stating that widgets can override their system-assigned default background color, has now been removed.
diff --git a/iOS/src/toga_iOS/widgets/base.py b/iOS/src/toga_iOS/widgets/base.py
@@ -13,8 +13,13 @@ def __init__(self, interface):
         self.native = None
         self.create()
 
-        # Override this attribute to set a different default background
-        # color for a given widget.
+        # Many widgets have a "transparent" background; however, some widgets use
+        # UIColor.ClearColor, and some use UIExtendedGrayColorSpace 0 0, which has
+        # slightly different color mixing characteristics. Widgets like TextInput use
+        # `None` as their initial background color, so that always adapts to light/dark
+        # mode. Preserve the initial background color on the freshly created widget so
+        # that we can reset back to that color when background_color is set to None. See
+        # #3104 for details.
         self._default_background_color = self.native.backgroundColor
 
     @abstractmethod
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		On iOS, an erroneous note stating that widgets can override their system-assigned default background color, has now been removed.