Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eaton-fix #841

Closed
wants to merge 3 commits into from
Closed

eaton-fix #841

wants to merge 3 commits into from

Conversation

h-leth
Copy link

@h-leth h-leth commented Jan 30, 2023

This is my fix for the Eaton issues

Fixes #836 and #829
And are the code that is posted in PR #837

Signed-off-by: Henning Leth <[email protected]>
Signed-off-by: Henning Leth <[email protected]>
@h-leth
Copy link
Author

h-leth commented Feb 1, 2023

Solves #831

Let me know if anything need to be changed

@scottlaird
Copy link
Contributor

I added the original Eaton support; this change looks good to me. I was about to do something similar to fix the build problem.

@scottlaird
Copy link
Contributor

As mentioned in #837, Eaton (really Akamai) seems to block Curl's User-Agent. Also, it looks like Eaton's upstream source for this moved to https://www.eaton.com/content/dam/eaton/products/backup-power-ups-surge-it-power-distribution/Firmware/eaton-pdu-g3-firmware-mib.zip, which would need an intermediate unzip step to get EATON-EPDU-MIB.zip. It's almost certainly easier to just fetch this from a different source, which is what this PR already does.

@SuperQ
Copy link
Member

SuperQ commented Feb 13, 2023

Since Eaton can't make their MIBs accessible, I think it's more appropriate that we simply remove them from the examples.

The generator.yml is not meant to be an exhaustive source of data, only a number of reasonable examples.

@h-leth
Copy link
Author

h-leth commented Feb 14, 2023

Since Eaton can't make their MIBs accessible, I think it's more appropriate that we simply remove them from the examples.

Sure I can remove them.

But what to do about issue #831, want to fix it in this PR or should I open a new one?
Or should that one be removed too? It's something with the new version of AIRESPACE-WIRELESS-MIB.my on https://github.com/cisco/cisco-mibs

@SuperQ
Copy link
Member

SuperQ commented Feb 14, 2023

Fixed with #843

@SuperQ SuperQ closed this Feb 14, 2023
@h-leth h-leth deleted the eaton-fix branch February 15, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EATON mib location is no longer valid
3 participants