-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eaton-fix #841
eaton-fix #841
Conversation
Signed-off-by: Henning Leth <[email protected]>
Signed-off-by: Henning Leth <[email protected]>
Signed-off-by: Henning Leth <[email protected]>
Solves #831 Let me know if anything need to be changed |
I added the original Eaton support; this change looks good to me. I was about to do something similar to fix the build problem. |
As mentioned in #837, Eaton (really Akamai) seems to block Curl's User-Agent. Also, it looks like Eaton's upstream source for this moved to https://www.eaton.com/content/dam/eaton/products/backup-power-ups-surge-it-power-distribution/Firmware/eaton-pdu-g3-firmware-mib.zip, which would need an intermediate unzip step to get EATON-EPDU-MIB.zip. It's almost certainly easier to just fetch this from a different source, which is what this PR already does. |
Since Eaton can't make their MIBs accessible, I think it's more appropriate that we simply remove them from the examples. The generator.yml is not meant to be an exhaustive source of data, only a number of reasonable examples. |
Sure I can remove them. But what to do about issue #831, want to fix it in this PR or should I open a new one? |
Fixed with #843 |
This is my fix for the Eaton issues
Fixes #836 and #829
And are the code that is posted in PR #837