-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generator lookups to match OIDs closer to the index OID. #828
Fix generator lookups to match OIDs closer to the index OID. #828
Conversation
…label Signed-off-by: Windischmann, Stephan <[email protected]>
72aff0b
to
3f70dc1
Compare
Interesting, can you point to any specific OIDs where this changes things? |
I have attached the MIB with which we noticed the issue. As an example, both SYMSOFT-SS7FILTER-0-MIB.txt and SYMSOFT-TRAFFICSIMULATOR-0-MIB.txt both have nodes with the label layerName. This is used to lookup a human readable name. |
Interesting, I was hoping this would fix the conflict in |
It looks like this affects the raritan module. Does the output change look right to you? Would you mind updating the snmp.yml so the generator test passes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs an update to the snmp.yml.
Signed-off-by: stephan-windischmann-sky <[email protected]>
53ff90b
to
d0f6670
Compare
The changes in snmp.yml look good to me. Thanks. |
Yikes, it looks like the git history got messed up. |
Signed-off-by: Stephan Windischmann <[email protected]>
d0f6670
to
ba620cb
Compare
Fixed git messup. snmp.yml is updated. |
Nice, thanks. |
* [ENHANCEMENT] generator: Add support for subsequent address family #782 * [ENHANCEMENT] generator: Fix lookups to match OIDs closer to the index OID. #828 * [FEATURE] Add a scaling factor #1026 * [FEATURE] generator: Enable passing input file, output file, and mibs dir as flags #1028 * [FEATURE] Add an offset factor #1029 * [BUGFIX] Fix and optimize generator Docker image building #1045 snmp.yml changes: * Override `bsnAPName` to DisplayString #660 * Import TP-Link EAP MIB #833 * Updated Mikrotik neighbor indexes make them unique #986 * Update PowerNet MIB to v4.5.1 #1003 * Refactor HOST-RESOURCES-MIB #1027 * Update keepalived MIB files to latest version #1044 Signed-off-by: SuperQ <[email protected]>
* [ENHANCEMENT] generator: Add support for subsequent address family #782 * [ENHANCEMENT] generator: Fix lookups to match OIDs closer to the index OID. #828 * [FEATURE] Add a scaling factor #1026 * [FEATURE] generator: Enable passing input file, output file, and mibs dir as flags #1028 * [FEATURE] Add an offset factor #1029 * [BUGFIX] Fix and optimize generator Docker image building #1045 snmp.yml changes: * Override `bsnAPName` to DisplayString #660 * Import TP-Link EAP MIB #833 * Updated Mikrotik neighbor indexes make them unique #986 * Update PowerNet MIB to v4.5.1 #1003 * Refactor HOST-RESOURCES-MIB #1027 * Update keepalived MIB files to latest version #1044 Signed-off-by: SuperQ <[email protected]>
* [ENHANCEMENT] generator: Add support for subsequent address family #782 * [ENHANCEMENT] generator: Fix lookups to match OIDs closer to the index OID. #828 * [FEATURE] Add a scaling factor #1026 * [FEATURE] generator: Enable passing input file, output file, and mibs dir as flags #1028 * [FEATURE] Add an offset factor #1029 * [BUGFIX] Fix and optimize generator Docker image building #1045 snmp.yml changes: * Override `bsnAPName` to DisplayString #660 * Import TP-Link EAP MIB #833 * Updated Mikrotik neighbor indexes make them unique #986 * Update PowerNet MIB to v4.5.1 #1003 * Refactor HOST-RESOURCES-MIB #1027 * Update keepalived MIB files to latest version #1044 Signed-off-by: SuperQ <[email protected]>
* [ENHANCEMENT] generator: Add support for subsequent address family #782 * [ENHANCEMENT] generator: Fix lookups to match OIDs closer to the index OID. #828 * [FEATURE] Add a scaling factor #1026 * [FEATURE] generator: Enable passing input file, output file, and mibs dir as flags #1028 * [FEATURE] Add an offset factor #1029 * [BUGFIX] Fix and optimize generator Docker image building #1045 snmp.yml changes: * Override `bsnAPName` to DisplayString #660 * Import TP-Link EAP MIB #833 * Updated Mikrotik neighbor indexes make them unique #986 * Update PowerNet MIB to v4.5.1 #1003 * Refactor HOST-RESOURCES-MIB #1027 * Update keepalived MIB files to latest version #1044 Signed-off-by: SuperQ <[email protected]>
When running the configuration generator with lookups were multilpe different nodes have the same label the generator was always grabbing the OID of the last MIB that was parsed.
I modified the lookup mechanism to first attempt to match the lookup node so that the OID matches that of the metric in all but the last branch.
In case no match is found, it reverts to the old behavior.