Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate UCD-SNMP-MIB OIDs #1200

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Deduplicate UCD-SNMP-MIB OIDs #1200

merged 1 commit into from
Jun 14, 2024

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Jun 12, 2024

Consolidate the use of UCD-SNMP-MIB into separate modules, rather than include them in individual device modules.

Consolidate the use of UCD-SNMP-MIB into separate modules, rather than
include them in individual device modules.

Signed-off-by: SuperQ <[email protected]>
@SuperQ
Copy link
Member Author

SuperQ commented Jun 12, 2024

CC @bastischubert Saves about 400 lines of snmp.yml.

@SuperQ SuperQ requested a review from RichiH June 12, 2024 07:58
@bastischubert
Copy link
Member

Looks good, we should at least document that the built in things for the synology and kemp_loadmaster will change (mikrotik change will most likely not have a real impact)

@SuperQ
Copy link
Member Author

SuperQ commented Jun 14, 2024

I have been adding these changes as notes to the release docs.

Copy link
Member

@jesusvazquez jesusvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (to unblock) I'm a bit lost with the changes its doing to be fair.

@SuperQ SuperQ merged commit fc2b4a2 into main Jun 14, 2024
6 checks passed
@SuperQ SuperQ deleted the superq/ucd branch June 14, 2024 13:33
SuperQ added a commit that referenced this pull request Jan 3, 2025
BREAKING CHANGES:

This version of the exporter introduces a cleaned up default snmp.yml that moved all
ucd-snmp-mib oids into a separate module.

If you used one of the following modules:
* synology
* ddwrt
* kemp_loadmaster 

you will need to change your scrape config to also include the ucd_la_table module as well.
See https://github.com/prometheus/snmp_exporter/tree/main?tab=readme-ov-file#multi-module-handling for further instructions.

* [CHANGE] generator: Update generator default MIBOPTS #1231
* [CHANGE] adopt log/slog, drop go-kit/log #1249
* [ENHANCEMENT] generator: Improve config error message #1274
* [FEATURE] add ParseDateAndTime type #1234 
* [FEATURE] Set UseUnconnectedUDPSocket option if one of the modules has if set #1247
* [FEATURE] add NTPTimeStamp type #1315
* [BUGFIX] fixed dashboard mixins #1319

snmp.yml changes:
* cleanup ucd-snmp-mibs #1200
  * moved oids from synology,ddwrt and kemp_loadmaster to new module ucd_la_table 
* Added support for Sophos XG Series #1239
* Added support for HPE #1267
* Added support for powercom #1275
* Added support for Cisco IMC #1293
* Updated mib for apc #1303
* Added support for TPLink DDM #1304

---------

Signed-off-by: Sebastian Schubert <[email protected]>
Signed-off-by: Sebastian Schubert <[email protected]>
Co-authored-by: Ben Kochie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants