Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNMP exporter doesn't have a version flag #716

Closed
johnseekins opened this issue Dec 23, 2021 · 1 comment · Fixed by #717
Closed

SNMP exporter doesn't have a version flag #716

johnseekins opened this issue Dec 23, 2021 · 1 comment · Fixed by #717

Comments

@johnseekins
Copy link

This is a relatively small request:

Most prometheus exporters have a version string, which makes it easy to verify we're running the expected version of a product with Ansible/etc. Can we add one to the SNMP exporter?
@SuperQ
Copy link
Member

SuperQ commented Dec 23, 2021

Good catch, it looks like the version flag register is missing. Easy to fix.

SuperQ added a commit that referenced this issue Dec 23, 2021
@SuperQ
Add version flag
cfbd125 
Add `--version` flag to kingpin.

Fixes: #716

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ mentioned this issue Dec 23, 2021
Merged
SuperQ added a commit that referenced this issue Jan 11, 2022
@SuperQ
Add version flag
956b4d6 
Add `--version` flag to kingpin.

Fixes: #716

Signed-off-by: SuperQ <[email protected]>
SuperQ added a commit that referenced this issue Jan 11, 2022
@SuperQ
Add version flag (#717)
2b78a71 
Add `--version` flag to kingpin.

Fixes: #716

Signed-off-by: SuperQ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add version flag prometheus/snmp_exporter
2 participants
@SuperQ @johnseekins