Skip to content

Conversation

@kadern0
Copy link
Contributor

@kadern0 kadern0 commented May 18, 2020

Fixes issue #294

Hi @bluecmd, please have a look and let me know if you think I should do any changes on the PR. Thanks!

Copy link
Contributor

@bluecmd bluecmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start!

@kadern0
Copy link
Contributor Author

kadern0 commented May 19, 2020

@bluecmd I think it is ready for a second round :)

Copy link
Contributor

@bluecmd bluecmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work! I'm not a maintainer however, so you need to track one down for their review.

Copy link
Collaborator

@pgier pgier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks very much for working on this!

Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants