Skip to content

fix info_schema_processlist collector, binlog dump may cause ‘write to net‘ a huge number #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix info_schema_processlist collector, binlog dump may cause ‘write to net‘ a huge number #381

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d2d8ad
fix info_schema_processlist collector, move binlog dump before normSt…
Apr 26, 2019
3a93e0c
restore format
Apr 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions collector/info_schema_processlist.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,10 @@ func (ScrapeProcesslist) Scrape(ctx context.Context, db *sql.DB, ch chan<- prome
func deriveThreadState(command string, state string) string {
var normCmd = strings.Replace(strings.ToLower(command), "_", " ", -1)
var normState = strings.Replace(strings.ToLower(state), "_", " ", -1)
// check if replication master first
if normCmd == "binlog dump" {
return "replication master"
}
// check if it's already a valid state
_, knownState := threadStateCounterMap[normState]
if knownState {
Expand All @@ -261,9 +265,6 @@ func deriveThreadState(command string, state string) string {
if normCmd == "query" {
return "executing"
}
if normCmd == "binlog dump" {
return "replication master"
}
return "other"
}

Expand Down