Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IBM Z HMC exporter #1160

Merged
merged 2 commits into from
Aug 24, 2018
Merged

Add IBM Z HMC exporter #1160

merged 2 commits into from
Aug 24, 2018

Conversation

Jakob-Naucke
Copy link
Contributor

I would like to add the zhmc-prometheus-exporter to the list of known exporters. It is an exporter for metrics from the IBM Z Hardware Management Console (ZHMC). Z is IBM’s product line of mainframe computers.

I have already added the ZHMC exporter to the list of allocated ports, under 9291.

@brian-brazil
Signed-off-by: Jakob-Naucke [email protected]

to the list of known exporters
Signed-off-by: Jakob-Naucke <[email protected]>
@Jakob-Naucke Jakob-Naucke changed the title Added IBM Z HMC exporter Add IBM Z HMC exporter Aug 24, 2018
@@ -148,6 +148,7 @@ wide variety of JVM-based applications, for example [Kafka](http://kafka.apache.
* [Confluence exporter](https://github.com/AndreyVMarkelov/prom-confluence-exporter)
* [Dovecot exporter](https://github.com/kumina/dovecot_exporter)
* [eBPF exporter](https://github.com/cloudflare/ebpf_exporter)
* [IBM Z HMC exporter](https://github.com/zhmcclient/zhmc-prometheus-exporter)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably go in the "Hardware related" section, where we have stuff like the IPMI exporter?

@brian-brazil
Copy link
Contributor

What do the output metrics for this look like? I suspect they're missing a zhmc_ prefix which you'd usually add.

@Jakob-Naucke
Copy link
Contributor Author

@juliusv We were unsure about the category as well; we decided to put it into "Miscellaneous" because due to the fact that it is the Hardware Management Console, it is not as close to the hardware as, say, an Nvidia GPU exporter. The "Hardware" category however is perfectly valid as well. I therefore moved the link into that category.

@brian-brazil I have edited the exporter such that all metrics have a zhmc_ prefix. This is now version 0.2.0.

@brian-brazil brian-brazil merged commit d55c60e into prometheus:master Aug 24, 2018
@brian-brazil
Copy link
Contributor

Thanks!

The smaller we can keep misc the better.

@Jakob-Naucke Jakob-Naucke deleted the zhmcexporter branch August 24, 2018 09:31
aylei pushed a commit to aylei/docs that referenced this pull request Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants