Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow configuration of PingTimeout/ReadIdleTimeout #512

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dongjiang1989
Copy link

Allow configuration of PingTimeout/ReadIdleTimeout at the HTTP2.

PingTimeout defaults to 15s, which is relaxed enough in most network conditions.

ReadIdleTimeout defaults to 1m, which I think is not going to cause performance issues.

Ref. kubernetes/kubernetes#95981

@roidelapluie
Copy link
Member

What is your usecase? I feel like PingTimeout might be tricky, how well is that supported by http2 vendors?

@dongjiang1989
Copy link
Author

What is your usecase? I feel like PingTimeout might be tricky, how well is that supported by http2 vendors?

When I use common to establish an http2 connection to nginx, the connection is found to be use of closed network connection.

Ref. kubernetes/kubernetes#95981

Using PingTimeout, the client will find that the connection is complete and respond, and actively close the connection.

@roidelapluie
Copy link
Member

Where do you plan to configure this? Are you using common in your own software or is it for prometheus?

@dongjiang1989
Copy link
Author

Where do you plan to configure this? Are you using common in your own software or is it for prometheus?

It is used for prometheus and prometheus-adapter frist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants