Re-enable HTTP/2 #325
Merged
Re-enable HTTP/2 #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beorn7
approved these changes
Sep 16, 2021
HTTP/2 has been tested and validated by some of our users. It is time to bring it back. Signed-off-by: Julien Pivotto <[email protected]>
|
Can you please review again? the comment was bad |
roidelapluie
force-pushed
the
enablehttp2
branch
from
ea2adaa
to
d6c7947
Compare
beorn7
requested changes
Sep 20, 2021
config/http_config.go
Outdated
Comment on lines
392
to
393
| // This is a temporary workaround, than be enabled if we see issues | ||
| // again in the short future. |
There was a problem hiding this comment.
This still doesn't sound quite right. Perhaps "This allows users to easily disable HTTP2 in case they run into issues again, but will be removed once we are confident that things work as expected."?
Signed-off-by: Julien Pivotto <[email protected]>
beorn7
approved these changes
Sep 20, 2021
LeviHarrison
pushed a commit
to LeviHarrison/common
that referenced
this pull request
Oct 9, 2021
* Re-enable HTTP/2 HTTP/2 has been tested and validated by some of our users. It is time to bring it back. Signed-off-by: Julien Pivotto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP/2 has been tested and validated by some of our users. It is time to
bring it back.
Signed-off-by: Julien Pivotto [email protected]