Add sigv4 module #310
Merged
Add sigv4 module #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 16, 2021 16:40
…d secret key Signed-off-by: Tyler Reid <[email protected]> Signed-off-by: Tyler Reid <[email protected]>
…roundtripper Signed-off-by: Tyler Reid <[email protected]>
5 tasks
pracucci
reviewed
Jun 18, 2021
Signed-off-by: Tyler Reid <[email protected]>
Member
|
yes, it would be nice to add a Makefile and call it from the main makefile or from ci |
| return fmt.Errorf("must provide a AWS SigV4 Access key and Secret Key if credentials are specified in the SigV4 config") | ||
| } | ||
| return nil | ||
| } |
Member
|
Thanks, I have added 2 small comments. |
added 3 commits
June 22, 2021 10:48
Signed-off-by: Tyler Reid <[email protected]>
Signed-off-by: Tyler Reid <[email protected]>
Signed-off-by: Tyler Reid <[email protected]>
pracucci
reviewed
Jun 23, 2021
Member
|
Thanks, we are getting close :) |
Signed-off-by: Tyler Reid <[email protected]>
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the sigv4 config and sig v4 roundtripper. Do I need to add a new makefile for this module as well?