Generate hashCAFile with SHA256 #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! All tests are broken and you did not sign your commit with DCO :) |
In a FIPS environment, it's much easier to switch to SHA256 than it is to verify and explain that any particular use of MD5 is actually safe in-context. Signed-off-by: Nick Thomas <[email protected]>
Author
|
Oops, sorry about that @roidelapluie . That'll teach me to try to use the in-browser editor 😅 I can see we're still failing on very old Go versions, I'll see if I can work out why that is. |
Member
|
You can remove them from our circleci config (we want to support go 1.13 onwards). |
Signed-off-by: Nick Thomas <[email protected]>
Author
|
Haha, that works too 😅 . Hopefully that's everything! |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been tasked with checking FIPS compliance of the GitLab codebase. One attribute of FIPS compliance is that MD5 hashes are frowned upon.
It's going to be much easier to switch to SHA256 for this specific use than to explain in detail why MD5 is fine 😅 so I'd love to get this merged.