Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS authentication using official exporter-toolkit #113

Merged
merged 1 commit into from
Jun 5, 2021

Conversation

tuannh99
Copy link
Contributor

@tuannh99 tuannh99 commented Jun 5, 2021

This enables TLS support for consul_exporter, using the official exporter-toolkit

level=info ts=2021-06-05T11:39:53.390Z caller=main.go:323 msg="Starting collectd_exporter" version="(version=0.5.0, branch=add-tls-authentication, revision=c541af78b805095c2e3ba6d989d525d34cc916ac)"
level=info ts=2021-06-05T11:39:53.390Z caller=main.go:324 msg="Build context" context="(go=go1.16.3, user=mymachine, date=20210605-11:38:38)"
level=info ts=2021-06-05T11:39:53.390Z caller=main.go:346 msg="Listening on address" address=:9103
level=info ts=2021-06-05T11:39:53.393Z caller=tls_config.go:224 msg="TLS is enabled." http2=true

CC @juliusv

@juliusv
Copy link
Member

juliusv commented Jun 5, 2021

👍 Thanks, looks good to me at a first glance! @roidelapluie to you too (as the exporter toolkit person)?

@roidelapluie
Copy link
Member

Does collectd support TLS? (I am asking because I know it does not accept TLS inboud last time I checked)

@juliusv
Copy link
Member

juliusv commented Jun 5, 2021

I'm not sure, as I've never dealt with collectd for real and only became the maintainer of this exporter by historical accident :) I do see some TLS options on https://collectd.org/documentation/manpages/collectd.conf.5.shtml, but not 100% if those are what you'd be looking for.

But in any case, will merge, thanks for checking as well!

@juliusv juliusv merged commit f81b12f into prometheus:master Jun 5, 2021
@tuannh99 tuannh99 deleted the add-tls-authentication branch June 6, 2021 05:02
@blkperl blkperl mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants