Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nocache url parameter option #1685

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions api/prometheus/v1/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -1079,6 +1079,7 @@ func (h *httpAPI) LabelValues(ctx context.Context, label string, matches []strin
type apiOptions struct {
timeout time.Duration
limit uint64
nocache bool
}

type Option func(c *apiOptions)
Expand All @@ -1099,6 +1100,13 @@ func WithLimit(limit uint64) Option {
}
}

// WithNoCache can be used to provide an optional nocache parameter for Query and QueryRange.
func WithNoCache() Option {
return func(o *apiOptions) {
o.nocache = true
}
}

func addOptionalURLParams(q url.Values, opts []Option) url.Values {
opt := &apiOptions{}
for _, o := range opts {
Expand All @@ -1113,6 +1121,10 @@ func addOptionalURLParams(q url.Values, opts []Option) url.Values {
q.Set("limit", strconv.FormatUint(opt.limit, 10))
}

if opt.nocache {
q.Set("nocache", "1")
}

return q
}

Expand Down