Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut 1.20.5 with the revert of #1424 (compareMetricFamilies) #1645

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

bwplotka
Copy link
Member

I spoke to a few people (e.g. @dashpole @dgrisonnet @kakkoyun @ArthurSens @vesari @logicalhan), and it feels it might be easier for everyone to revert.

cc @machine424

Rationales:

  • We feel the pain of the subsequent changes in Kubernetes and other places (e.g. Google). We want to make sure downstream users trust client_golang as a stable and minimal dependency.
  • Reverting this change should NOT break (re-break) users who fixed their tests and switched to a new behaviour.
  • We broke users who used this API to test for a metric to be absent without replacement (thanks @dgrisonnet for innovating here in a PR).
  • Based on @dashpole work on the upgrade, this change didn't provide any major "improvement" in Kubernetes tests so far.

I propose we revert this, and work on a long term solution. With the team we also discussed a way, where every client_golang release pipeline could propose an upgrade PR to a Kubernetes library that heavily depends on client_golang and check if the CI passes (compatibility check with a big user) -- to avoid similar issues in the future.

Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting this change should NOT break (re-break) users who fixed their tests and switched to a new behaviour.

LGTM as long as the above was properly tested 😅!

@ArthurSens
Copy link
Member

Impressive that we've got a fifth patch release this time. As discussed in our call today, creating release candidates would improve everybody's life by a ton!

Issue opened here: #1646

@bwplotka
Copy link
Member Author

bwplotka commented Oct 15, 2024

LGTM as long as the above was properly tested 😅!

Yea, we only remove a check, so except this being more error-prone (we will reopen #1351), those who already did a work to adjust their test should be not impacted. However, for empirical test purposes, I kindly asked @krajorama to create a quick PR on Mimir with PR to double check (:

EDIT: One test failed grafana/mimir#9624 (comment), but only because a different error message was produced. I think it's acceptable or not as smooth as I expected. Seems like still it's more annoying to keep this change vs revert, so proceeding.

@bwplotka bwplotka merged commit 48e12a1 into release-1.20 Oct 15, 2024
10 checks passed
@bwplotka bwplotka deleted the cut-1204-pr1424 branch October 15, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants