Remove bucket option for now. #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bwplotka <[email protected]>
kakkoyun
approved these changes
Aug 5, 2022
kakkoyun
added a commit
that referenced
this pull request
Aug 5, 2022
…uration. (#1102) * goCollector: Added rule support for granular metric configuration. Fixes: #1089 Signed-off-by: bwplotka <[email protected]> * Added compatibility mode with old options. (#1107) * Added compatibility mode with old options. Signed-off-by: bwplotka <[email protected]> * Copyright header. Signed-off-by: bwplotka <[email protected]> * Remove bucket option for now. (#1108) Signed-off-by: bwplotka <[email protected]> * collectors/GoCollector: Add tests and examples (#1109) * Add tests and examples Signed-off-by: Kemal Akkoyun <[email protected]> * Add docs for the presets Signed-off-by: Kemal Akkoyun <[email protected]> Co-authored-by: Kemal Akkoyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bwplotka [email protected]
Let's apply YAGNI and add that only when requested. It's not trivial code to be changed in bach Histogram to downsample buckets