Ensure tests verify request params #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephwoodward
force-pushed
the
1034_verify_request_params
branch
from
fa690a2
to
5fc828e
Compare
josephwoodward
commented
May 6, 2022
| @@ -259,7 +279,7 @@ func TestAPIs(t *testing.T) { | |||
| reqPath: "/api/v1/query", | |||
| reqParam: url.Values{ | |||
| "query": []string{"2"}, | |||
| "time": []string{testTime.Format(time.RFC3339Nano)}, | |||
There was a problem hiding this comment.
Tests formatted via testTime.Format(time.RFC3339Nano) currently fail with the following error message:
unexpected request parameters: want map[query:[2] time:[1651799194.268618]], got map[query:[2] time:[2022-05-06T02:06:34.268618+01:00]]
so I've updated the tests to use formatTime for the time being, which is the same function used by the client.
|
We've removed 1.16 support. It worths rebasing #1062 |
|
@kakkoyun Okay, thanks. Hoping to getting around finishing this PR soon. |
Signed-off-by: Joseph Woodward <[email protected]>
Signed-off-by: Joseph Woodward <[email protected]>
bwplotka
force-pushed
the
1034_verify_request_params
branch
from
5480d34
to
778954f
Compare
|
Rebased your PR if you don't mind 🙈 |
Signed-off-by: bwplotka <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.