testutil: Add ScrapeAndCompare #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @bwplotka let me know what you think about this if this is okay, could you please approve it's workflows? thanks |
sazary
force-pushed
the
add-scrape-and-compare
branch
from
d13b534
to
a76f8c8
Compare
dohnto
reviewed
May 4, 2022
Signed-off-by: sazary <[email protected]>
Signed-off-by: sazary <[email protected]>
sazary
force-pushed
the
add-scrape-and-compare
branch
from
a76f8c8
to
86f0b14
Compare
|
@sazary Is it possible for you to rebase and fix conflicts? |
Signed-off-by: Kemal Akkoyun <[email protected]>
|
@sazary I've fixed the conflicts for you ;) It's good to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #993 by @bwplotka, it would be nice to have a utility function that scrapes an exporter and compares it to a set of expected values.
I've mostly copied the approach used in kubernetes/kubernetes#108277 and refactored some minor functions in the
testutilpackage.Signed-off-by: sazary [email protected]