Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add probe_dns_query_succeeded metric #990

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

danteu
Copy link
Contributor

@danteu danteu commented Nov 25, 2022

Currently, one may not be able to differentiate between a query refusal
by the target and the target not responding to a query. These two cases
can have very different ramifications.

This patch adds the probe_dns_query_succeeded gauge which is 1 if and
only if the DNS query was executed correctly, i.e., that the target
host has sent a response, and 0 otherwise.

Resolves #474

Signed-off-by: Daniel Teunis [email protected]

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metric name / help doesn't seem to match what this is really about.

prober/dns.go Outdated Show resolved Hide resolved
Currently, one may not be able to differentiate between a query refusal
by the target and the target not responding to a query. These two cases
can have very different ramifications.

This patch adds the probe_dns_query_succeeded gauge which is 1 if and
only if the DNS query was executed correctly, i.e., that the target
host has sent a response, and 0 otherwise.

Resolves prometheus#474

Signed-off-by: Daniel Teunis <[email protected]>
@danteu danteu changed the title Add probe_dns_target_reachable metric Add probe_dns_query_succeeded metric Nov 26, 2022
@danteu danteu requested review from SuperQ and removed request for mem and electron0zero December 1, 2022 14:07
Copy link
Member

@electron0zero electron0zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks :)

@SuperQ SuperQ merged commit f70a422 into prometheus:master Dec 1, 2022
roidelapluie added a commit to roidelapluie/blackbox_exporter that referenced this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants