Add hostname parameter for TCP probe #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lyas Spiehler <[email protected]>
lspiehler
force-pushed
the
servername-http-query-param-for-tcp
branch
from
4b0fc5e
to
f859c8e
Compare
Signed-off-by: Lyas Spiehler <[email protected]>
Signed-off-by: Lyas Spiehler <[email protected]>
Signed-off-by: Lyas Spiehler <[email protected]>
|
looking for comments from @mem @roidelapluie, will merge if there are no comments :) |
|
This seems like a missing feature for tcp probes (since http probes already expose hostname). Would love to see this ship soon! |
lspiehler
force-pushed
the
servername-http-query-param-for-tcp
branch
2 times, most recently
from
6a0c972
to
b354fd3
Compare
Signed-off-by: Lyas Spiehler <[email protected]>
lspiehler
force-pushed
the
servername-http-query-param-for-tcp
branch
from
b354fd3
to
d207f64
Compare
electron0zero
approved these changes
Feb 1, 2023
|
merged, thanks @lspiehler :) |
SuperQ
added a commit
that referenced
this pull request
May 16, 2023
* [CHANGE] Make Proxy Connect Headers consistent with Prometheus #1008 * [FEATURE] Add hostname parameter for TCP probe #981 * [FEATURE] Add support for HTTP request body as file #987 Signed-off-by: SuperQ <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to set the TLS server name for TCP probes using the hostname parameter just like #823 did for HTTP probes. It was mentioned by @Nothing4You in #624, and its something I need for monitoring in my environment as well.