Add support for configuring gRPC metadata#956
Merged
Conversation
|
Hi! We also need this functionality. We can't use grpc prober with authorization without metadata (need headers). Thanks. |
|
Hey 👋🏻 Any update on the review of this PR ? It would be useful for authentication. |
electron0zero
requested changes
Oct 29, 2025
Member
|
please rebase with master as well, and resolve conflicts. |
Signed-off-by: Alessandro Verzicco <8068317+averzicco@users.noreply.github.com> Signed-off-by: averzicco <8068317+averzicco@users.noreply.github.com> Signed-off-by: Alessandro Verzicco <8068317+averzicco@users.noreply.github.com>
Signed-off-by: Alessandro Verzicco <8068317+averzicco@users.noreply.github.com>
Signed-off-by: Alessandro Verzicco <8068317+averzicco@users.noreply.github.com>
Co-authored-by: Suraj Nath <9503187+electron0zero@users.noreply.github.com> Signed-off-by: Alessandro Verzicco <8068317+averzicco@users.noreply.github.com>
Member
|
waiting to get more comments from other maintainers. feel free to ping me to merge this, if there are no comments in few weeks. |
Contributor
Author
|
@electron0zero I guess now it's possible to merge this PR |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / Which issue(s) does the PR fix:
Hi, I've noticed there is an issue to request support for gRPC metadata (#946), so this PR is to add that support.
Fixes: #946
Does this PR introduce a user-facing change?
Checklist
release-notessection of PR Desc.