Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use preferred protocol first when resolving hostname #728

Merged
merged 5 commits into from
Jan 5, 2021
Merged

Use preferred protocol first when resolving hostname #728

merged 5 commits into from
Jan 5, 2021

Commits on Jan 3, 2021

  1. Use preferred protocol first when resolving hostname 

    Prior to this change, LookupIPAddr() is used to do the DNS query,
which sends two DNS queries for A/AAAA records, even if the config has
preferred protocol set to ip4 and does not allow fallback protocol.

This change will change to use LookupIP() with the preferred protocol,
and only try fallback protocol if it's set to true. In most cases doing
this will save one RTT of DNS query.

Signed-off-by: Yuchen Ying <[email protected]>
    @yegle
    yegle committed Jan 3, 2021
    Configuration menu
    Copy the full SHA
    5487581 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2021

  1. Use example.com hostname in test. 

    Signed-off-by: Yuchen Ying <[email protected]>
    @yegle
    yegle committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    923274a View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Inline LookupIP function call. 

    Signed-off-by: Yuchen Ying <[email protected]>
    @yegle
    yegle committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    d08e1b0 View commit details
    Browse the repository at this point in the history

  2. Remove unused struct. 

    Signed-off-by: Yuchen Ying <[email protected]>
    @yegle
    yegle committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    5b10683 View commit details
    Browse the repository at this point in the history

  3. Make full use of named return variables and simplify the logic. 

    Signed-off-by: Yuchen Ying <[email protected]>
    @yegle
    yegle committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    f44254d View commit details
    Browse the repository at this point in the history