Add support for DoT to DNS probes #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I can see this being confusing if it silently doesn't do anything when UDP is asked for. Docs also need updating. |
|
@brian-brazil do you want me to error out when UDP and DoT is chosen? I’ll update the docs shortly. |
|
An error would do it. |
edevil
force-pushed
the
add_dot
branch
2 times, most recently
from
0210007
to
df4e7b5
Compare
|
@brian-brazil Added error case, and docs. |
CONFIGURATION.md
Outdated
| @@ -153,6 +153,9 @@ tls_config: | |||
|
|
|||
| [ transport_protocol: <string> | default = "udp" ] # udp, tcp | |||
|
|
|||
| # Whether to use DNS over TLS. This only makes sense with TCP transport protocol. | |||
There was a problem hiding this comment.
This only works with TCP.
Signed-off-by: André Cruz <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new DNS probe option
dns_over_tlsto enable DoT on DNS probes.