[dns] Allow to specify query Class #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-brazil
reviewed
Jun 8, 2020
| var ok bool | ||
| qc, ok = dns.StringToClass[module.DNS.QueryClass] | ||
| if !ok { | ||
| level.Error(logger).Log("msg", "Invalid query class", "Class seen", module.DNS.QueryClass, "Existing classes", dns.ClassToString) |
There was a problem hiding this comment.
This should be done in the config so that it can be caught when the config is loaded.
There was a problem hiding this comment.
Would that mean the QueryType check L148 (should be also done in the config?
Would you accept a 2nd PR to move both checks outside this file?
There was a problem hiding this comment.
Indeed, it should be. It's a small enough change it can all be done here.
There was a problem hiding this comment.
done, sorry for the delay.
I added config checks but also kept the existing code in the prober.
Signed-off-by: Baptiste Courtois <[email protected]>
|
Did you get a chance to make that final change? I'd like to get a release out soon and would like to include this PR. |
This allows to catch simple config errors earlier. Signed-off-by: Baptiste Courtois <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In some cases we might want to probe other DNS class than the INET one; for instance we could probe the server version often exposed in a
TXT CH version.bindrecord.This PR offers the ability to do so by setting
query_classin your prober configuration, the default is"IN"as it was before.Implementation note
Most of the code is a copy/paste/replace of the
query_typesetting; except that thesetQuestioncall has been replaced by its "slightly more verbose, but more flexible" alternative.