Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add none/all matches to DNS RRset validation #552

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

wodity
Copy link
Contributor

@wodity wodity commented Nov 20, 2019

The current validators for the DNS probers (if_matches/if_not_matches) pass if any record matches/does not match. This patch adds the opposite sense of each, so that a validation will pass if no records match, or all records match. This is much more useful for example with TXT records where you might want to check if a particular record is present or not without failing if any record does not match.

@brian-brazil
Copy link
Contributor

Can you do a make format to make CI happy?

@wodity
Copy link
Contributor Author

wodity commented Nov 21, 2019

Updated.

@brian-brazil
Copy link
Contributor

The configuration docs need updating too.

@wodity
Copy link
Contributor Author

wodity commented Nov 21, 2019

Ah, missed that. Updated those too.

@brian-brazil brian-brazil merged commit 3a08e67 into prometheus:master Nov 21, 2019
@brian-brazil
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants