Change the front page links to probe logs into relative links #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The front page contains a table of links to logs from the most recent probes. These links were accidentally changed to absolute links in 252a878, in a form that doesn't work when using --web.external-url. Rather than prefixing these with the external URL (if set), we return them to being relative links, as they are meant to be (per issue prometheus#519). Fixes prometheus#519 Signed-off-by: Chris Siebenmann <[email protected]>
|
Thanks! |
|
@brian-brazil, This PR should be a part of tag 0.15.1, am i understand it right? When it planned to be released? |
|
I'm waiting to see if there's any other issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The front page contains a table of links to logs from the most recent
probes. These links were accidentally changed to absolute links in
252a878, in a form that doesn't work when using --web.external-url.
Rather than prefixing these with the external URL (if set), we return
them to being relative links, as they are meant to be (per issue #519).
Fixes #519
Signed-off-by: Chris Siebenmann [email protected]