Account response read time for http prober #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobrik
force-pushed
the
transfer-time-fix
branch
from
2ecc803
to
3307978
Compare
prober/http.go
Outdated
| io.Copy(ioutil.Discard, resp.Body) | ||
| resp.Body.Close() | ||
| }() | ||
| requestErrored := err != nil |
There was a problem hiding this comment.
It'd be usual to put parens around the RHS here
prober/http.go
Outdated
| resp.Body.Close() | ||
| } | ||
|
|
||
| // At this point body is fully read and we can write end time |
bobrik
force-pushed
the
transfer-time-fix
branch
2 times, most recently
from
8550dd0
to
6bf5cc5
Compare
Withot this change `transfer` time is near zero, because `trace.end` time is clocked when response body is available, not when it's read. Signed-off-by: Ivan Babrou <[email protected]>
bobrik
force-pushed
the
transfer-time-fix
branch
from
6bf5cc5
to
160a02d
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Withot this change
transfertime is near zero, becausetrace.endtime is clocked when response body is available, not when it's read.cc @discordianfish