-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ICMP duration metrics #346
Conversation
prober/icmp.go
Outdated
|
||
durationGaugeVec = prometheus.NewGaugeVec(prometheus.GaugeOpts{ | ||
Name: "probe_icmp_duration_seconds", | ||
Help: "Duration of http request by phase, summed over all redirects", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs updating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whups, copy-pasta. :)
I did some testing, the Go ICMP code seems way slower than the normal C
With the blackbox_exporter:
Go seems to add about 200us to the ping time. (average 556us) This is still far more accurate than the full
|
FYI, Travis is failing due to Go 1.11 |
Add a gauge to measure various parts of the ICMP probe. Signed-off-by: Ben Kochie <[email protected]>
Update travis config to match upstream prometheus. Signed-off-by: Ben Kochie <[email protected]>
@brian-brazil @SuperQ Does |
Same here... |
@SuperQ @brian-brazil Similarly, I don’t have an ICMP indicator here. |
Add a gauge to measure various parts of the ICMP probe.
Fixes: #315